Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workflow] fixed example check workflow #2554

Merged
merged 2 commits into from Feb 6, 2023
Merged

Conversation

FrankLeeeee
Copy link
Contributor

馃搶 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

馃毃 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

Fixed #2553

馃摑 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

This PR does 2 things:

  1. fixed the matrix strategy such that other jobs will not stopped if any job fails
  2. separate the workflow to three yaml files corresponding to different event trigger for better readability and maintenability
  3. updated readme to categorize the workflows based on functionality

馃挜 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

猸愶笍 Do you enjoy contributing to Colossal-AI?

  • 馃対 Yes, I do.
  • 馃寶 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

Your pre-commit check failed, follow the steps to run pre-commit on your file for code style consistency.

  1. install pre-commit via "pip install pre-commit"
  2. install pre-commit hooks via "pre-commit install"
  3. run pre-commit on file with format error via "pre-commit run --files path" by replacing "path" with the actual file path
  4. commit and push to your branch

View your job at https://github.com/hpcaitech/ColossalAI/actions/runs/4080580211.
Read our "CONTRIBUTING.md" for more reference to the code style.

@FrankLeeeee FrankLeeeee added bug Something isn't working example example-related issuer or pull request labels Feb 3, 2023
@FrankLeeeee FrankLeeeee merged commit ba47517 into main Feb 6, 2023
@FrankLeeeee FrankLeeeee deleted the hotfix/scheduled-workflow branch February 6, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working DevOps example example-related issuer or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[devops] example check scheduled workflow fails
1 participant