Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] fixed the triton version for testing #2608

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

FrankLeeeee
Copy link
Contributor

@FrankLeeeee FrankLeeeee commented Feb 7, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

Fixed #2609 .

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

This PR updated the triton requirement to a valid triton release so that the build workflow can pass.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@FrankLeeeee FrankLeeeee changed the title [workflow] fixed the build workflow [test] fixed the triton version for testing Feb 7, 2023
@FrankLeeeee FrankLeeeee added the bug Something isn't working label Feb 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

The code coverage for the changed files is 87%.

Click me to view the complete report
Name                                  Stmts   Miss  Cover
---------------------------------------------------------
colossalai/amp/apex_amp/apex_amp.py      15      2    87%
---------------------------------------------------------
TOTAL                                    15      2    87%

@hpcaitech hpcaitech deleted a comment from github-actions bot Feb 7, 2023
@oahzxl
Copy link
Contributor

oahzxl commented Feb 7, 2023

lgtm

@FrankLeeeee FrankLeeeee merged commit 8518263 into hpcaitech:main Feb 7, 2023
@FrankLeeeee FrankLeeeee deleted the hotfix/build-ci branch February 7, 2023 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Testing failed due to triton
2 participants