Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[autoparallel] refactor handlers which reshape input tensors #2615

Merged

Conversation

YuliangLiu0306
Copy link
Contributor

@YuliangLiu0306 YuliangLiu0306 commented Feb 7, 2023

馃搶 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

馃毃 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

馃摑 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

馃挜 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

猸愶笍 Do you enjoy contributing to Colossal-AI?

  • 馃対 Yes, I do.
  • 馃寶 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@YuliangLiu0306 YuliangLiu0306 linked an issue Feb 7, 2023 that may be closed by this pull request
@YuliangLiu0306 YuliangLiu0306 added Run Build and Test auto-parallel related to the auto-parallel feature labels Feb 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

The code coverage for the changed files is 38%.

Click me to view the complete report
Name                                                                                                 Stmts   Miss  Cover
------------------------------------------------------------------------------------------------------------------------
colossalai/auto_parallel/tensor_shard/node_handler/__init__.py                                          27      0   100%
colossalai/auto_parallel/tensor_shard/node_handler/default_reshape_handler.py                           38     24    37%
colossalai/auto_parallel/tensor_shard/node_handler/permute_handler.py                                   44     32    27%
colossalai/auto_parallel/tensor_shard/node_handler/split_handler.py                                     36     24    33%
colossalai/auto_parallel/tensor_shard/node_handler/strategy/__init__.py                                 19      0   100%
colossalai/auto_parallel/tensor_shard/node_handler/strategy/matmul_strategy_generator.py               371     61    84%
colossalai/auto_parallel/tensor_shard/node_handler/strategy/reshape_generator.py                       178    155    13%
colossalai/auto_parallel/tensor_shard/node_handler/transpose_handler.py                                 36     24    33%
colossalai/auto_parallel/tensor_shard/node_handler/view_handler.py                                      28     15    46%
tests/test_auto_parallel/test_tensor_shard/test_node_handler/test_default_reshape_handler.py            48     34    29%
tests/test_auto_parallel/test_tensor_shard/test_node_handler/test_getitem_handler.py                   111     77    31%
tests/test_auto_parallel/test_tensor_shard/test_node_handler/test_permute_and_transpose_handler.py     245    213    13%
tests/test_auto_parallel/test_tensor_shard/test_node_handler/test_split_handler.py                     186    154    17%
tests/test_auto_parallel/test_tensor_shard/test_node_handler/test_view_handler.py                      183    152    17%
------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                 1550    965    38%

@FrankLeeeee FrankLeeeee merged commit 37df666 into hpcaitech:main Feb 8, 2023
@YuliangLiu0306 YuliangLiu0306 self-assigned this Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-parallel related to the auto-parallel feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: refactor reshape handlers
2 participants