Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chatgpt] fix ppo training hanging problem with gemini #3162

Merged
merged 2 commits into from
Mar 17, 2023

Conversation

ver217
Copy link
Member

@ver217 ver217 commented Mar 17, 2023

馃搶 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

馃毃 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

Closes #3161

馃摑 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

  1. Update examples/train_prompts.py to ensure each process has the same generation steps.
  2. Update generation early stopping condition by considering DDP scheme.

馃挜 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

猸愶笍 Do you enjoy contributing to Colossal-AI?

  • 馃対 Yes, I do.
  • 馃寶 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@ver217 ver217 added bug Something isn't working chatgpt ChatGPT Application labels Mar 17, 2023
@ver217 ver217 merged commit c474fda into hpcaitech:main Mar 17, 2023
@ver217 ver217 deleted the hotfix/chatgpt-gemini branch March 17, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chatgpt ChatGPT Application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: chatgpt ppo training hangs when using gemini
2 participants