Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] fixed torchrec model test #3167

Merged

Conversation

FrankLeeeee
Copy link
Contributor

@FrankLeeeee FrankLeeeee commented Mar 17, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

Fixed #3168

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

This PR fixed the tests related to the torchrec model.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@github-actions
Copy link
Contributor

The code coverage for the changed files is 91%.

Click me to view the complete report
Name                                                                 Stmts   Miss  Cover
----------------------------------------------------------------------------------------
tests/kit/model_zoo/torchrec/torchrec.py                                37      0   100%
tests/test_fx/test_tracer/test_torchrec_model/test_deepfm_model.py      40      5    88%
tests/test_fx/test_tracer/test_torchrec_model/test_dlrm_model.py        42      6    86%
----------------------------------------------------------------------------------------
TOTAL                                                                  119     11    91%

@github-actions
Copy link
Contributor

The code coverage for the changed files is 73%.

Click me to view the complete report
Name                                                                 Stmts   Miss  Cover
----------------------------------------------------------------------------------------
tests/kit/model_zoo/torchrec/torchrec.py                                37      0   100%
tests/test_booster/test_mixed_precision/test_fp16_torch.py              22      0   100%
tests/test_fx/test_tracer/test_torchrec_model/test_deepfm_model.py      38     28    26%
tests/test_fx/test_tracer/test_torchrec_model/test_dlrm_model.py        40     30    25%
tests/test_gemini/update/test_fwd_bwd.py                                83      1    99%
----------------------------------------------------------------------------------------
TOTAL                                                                  220     59    73%

@FrankLeeeee FrankLeeeee merged commit 1ad3a63 into hpcaitech:main Mar 20, 2023
@FrankLeeeee FrankLeeeee deleted the hotfix/torchrec-model-test-kit branch March 20, 2023 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: torchrec model is not working in test
2 participants