Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] fixed torchrec registration in model zoo #3177

Merged
merged 4 commits into from
Mar 20, 2023

Conversation

FrankLeeeee
Copy link
Contributor

@FrankLeeeee FrankLeeeee commented Mar 20, 2023

馃搶 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

馃毃 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

Fixed #3049

馃摑 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

This PR fixed the torchrec registration such that the torchrec test can pass successfully.

馃挜 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

猸愶笍 Do you enjoy contributing to Colossal-AI?

  • 馃対 Yes, I do.
  • 馃寶 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@github-actions
Copy link
Contributor

The code coverage for the changed files is 91%.

Click me to view the complete report
Name                                                                 Stmts   Miss  Cover
----------------------------------------------------------------------------------------
tests/test_fx/test_tracer/test_torchrec_model/test_deepfm_model.py      37      3    92%
tests/test_fx/test_tracer/test_torchrec_model/test_dlrm_model.py        39      4    90%
----------------------------------------------------------------------------------------
TOTAL                                                                   76      7    91%

2 similar comments
@github-actions
Copy link
Contributor

The code coverage for the changed files is 91%.

Click me to view the complete report
Name                                                                 Stmts   Miss  Cover
----------------------------------------------------------------------------------------
tests/test_fx/test_tracer/test_torchrec_model/test_deepfm_model.py      37      3    92%
tests/test_fx/test_tracer/test_torchrec_model/test_dlrm_model.py        39      4    90%
----------------------------------------------------------------------------------------
TOTAL                                                                   76      7    91%

@github-actions
Copy link
Contributor

The code coverage for the changed files is 91%.

Click me to view the complete report
Name                                                                 Stmts   Miss  Cover
----------------------------------------------------------------------------------------
tests/test_fx/test_tracer/test_torchrec_model/test_deepfm_model.py      37      3    92%
tests/test_fx/test_tracer/test_torchrec_model/test_dlrm_model.py        39      4    90%
----------------------------------------------------------------------------------------
TOTAL                                                                   76      7    91%

@FrankLeeeee FrankLeeeee changed the title [NOT DO MERGE] [test] fixed torchrec registration in model zoo Mar 20, 2023
@github-actions
Copy link
Contributor

The code coverage for the changed files is 91%.

Click me to view the complete report
Name                                                                 Stmts   Miss  Cover
----------------------------------------------------------------------------------------
tests/kit/model_zoo/torchrec/torchrec.py                                66      6    91%
tests/test_fx/test_tracer/test_torchrec_model/test_deepfm_model.py      37      3    92%
tests/test_fx/test_tracer/test_torchrec_model/test_dlrm_model.py        39      4    90%
----------------------------------------------------------------------------------------
TOTAL                                                                  142     13    91%

@FrankLeeeee FrankLeeeee merged commit 085e7f4 into hpcaitech:main Mar 20, 2023
@FrankLeeeee FrankLeeeee deleted the hotfix/torchrec-ci branch March 20, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[test] add test set for mainstream model zoos
2 participants