Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dtensor] updated api and doc #3845

Merged

Conversation

FrankLeeeee
Copy link
Contributor

@FrankLeeeee FrankLeeeee commented May 25, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

Fixed #3921

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

This PR updated the API usage and documentation of DTensor.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@FrankLeeeee FrankLeeeee added enhancement New feature or request API related to API changes labels May 25, 2023
@FrankLeeeee FrankLeeeee changed the base branch from main to feature/dtensor May 25, 2023 08:04
@FrankLeeeee FrankLeeeee marked this pull request as draft June 5, 2023 08:00
@FrankLeeeee FrankLeeeee marked this pull request as ready for review June 5, 2023 08:01
@FrankLeeeee FrankLeeeee force-pushed the refactor/dtensor branch 2 times, most recently from 17468e4 to d6e0e3f Compare June 7, 2023 07:21
@FrankLeeeee FrankLeeeee closed this Jun 7, 2023
@FrankLeeeee FrankLeeeee reopened this Jun 7, 2023
@FrankLeeeee FrankLeeeee force-pushed the refactor/dtensor branch 2 times, most recently from ed1d3f4 to f35ced9 Compare June 7, 2023 10:08
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

The code coverage for the changed files is 87%.

Click me to view the complete report
Name                                                      Stmts   Miss  Cover
-----------------------------------------------------------------------------
colossalai/device/device_mesh.py                            143      6    96%
colossalai/lazy/lazy_init.py                                299     40    87%
colossalai/tensor/comm_spec.py                              253     93    63%
colossalai/tensor/d_tensor/__init__.py                        3      0   100%
colossalai/tensor/d_tensor/comm_spec.py                     151     35    77%
colossalai/tensor/d_tensor/d_tensor.py                       67     11    84%
colossalai/tensor/d_tensor/layout.py                         38      1    97%
colossalai/tensor/d_tensor/layout_converter.py              202     13    94%
colossalai/tensor/d_tensor/sharding_spec.py                 105     14    87%
tests/test_device/test_device_mesh.py                        11      1    91%
tests/test_device/test_init_logical_pg.py                    27      1    96%
tests/test_lazy/lazy_init_utils.py                           71     14    80%
tests/test_lazy/test_distribute.py                           73      3    96%
tests/test_tensor/test_dtensor/test_comm_spec.py             81      1    99%
tests/test_tensor/test_dtensor/test_dtensor.py               67      5    93%
tests/test_tensor/test_dtensor/test_layout_converter.py      91      1    99%
tests/test_tensor/test_shape_consistency.py                  50      2    96%
tests/test_tensor/test_sharded_linear.py                    130      1    99%
tests/test_tensor/test_sharding_spec.py                      13      1    92%
-----------------------------------------------------------------------------
TOTAL                                                      1875    243    87%

@FrankLeeeee FrankLeeeee merged commit eb39154 into hpcaitech:feature/dtensor Jun 8, 2023
5 of 6 checks passed
@FrankLeeeee FrankLeeeee deleted the refactor/dtensor branch June 8, 2023 02:18
@FrankLeeeee FrankLeeeee linked an issue Jun 9, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API related to API changes enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dtensor] refactor dtensor API
2 participants