Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zero] allow passing process group to zero12 #4153

Merged
merged 3 commits into from
Jul 4, 2023
Merged

[zero] allow passing process group to zero12 #4153

merged 3 commits into from
Jul 4, 2023

Conversation

Gy-Lu
Copy link
Contributor

@Gy-Lu Gy-Lu commented Jul 4, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

fixed #4151

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

This PR support passing dp and tp process_group to low_level_zero, which further supports the new processGroupMesh.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@Gy-Lu Gy-Lu added API related to API changes compatibility related to compatibility labels Jul 4, 2023
@Gy-Lu Gy-Lu linked an issue Jul 4, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

The code coverage for the changed files is 86%.

Click me to view the complete report
Name                                                           Stmts   Miss  Cover
----------------------------------------------------------------------------------
colossalai/booster/booster.py                                     64     10    84%
colossalai/booster/plugin/gemini_plugin.py                       110      9    92%
colossalai/booster/plugin/low_level_zero_plugin.py                96      9    91%
colossalai/booster/plugin/plugin_base.py                          40     10    75%
colossalai/booster/plugin/torch_ddp_plugin.py                     66      2    97%
colossalai/booster/plugin/torch_fsdp_plugin.py                    97     13    87%
colossalai/zero/low_level/_utils.py                              119     66    45%
colossalai/zero/low_level/bookkeeping/bucket_store.py             51      0   100%
colossalai/zero/low_level/bookkeeping/gradient_store.py           31      1    97%
colossalai/zero/low_level/bookkeeping/parameter_store.py          16      0   100%
colossalai/zero/low_level/low_level_optim.py                     243     18    93%
tests/test_booster/test_plugin/test_low_level_zero_plugin.py      59      6    90%
tests/test_zero/test_low_level/test_grad_acc.py                   92     31    66%
tests/test_zero/test_low_level/test_zero1_2.py                   102      1    99%
tests/test_zero/test_low_level/test_zero_init.py                  40      4    90%
tests/test_zero/test_low_level/test_zero_tp.py                    66      1    98%
----------------------------------------------------------------------------------
TOTAL                                                           1292    181    86%

@ver217 ver217 merged commit 3b64147 into hpcaitech:feature/zero Jul 4, 2023
6 checks passed
@Gy-Lu Gy-Lu deleted the feature/zero branch July 4, 2023 09:41
kurisusnowdeng pushed a commit to kurisusnowdeng/ColossalAI that referenced this pull request Jul 10, 2023
* allow passing process group to zero12

* union tp-zero and normal-zero

* polish code
kurisusnowdeng pushed a commit to kurisusnowdeng/ColossalAI that referenced this pull request Jul 12, 2023
* allow passing process group to zero12

* union tp-zero and normal-zero

* polish code
kurisusnowdeng pushed a commit to kurisusnowdeng/ColossalAI that referenced this pull request Jul 12, 2023
* allow passing process group to zero12

* union tp-zero and normal-zero

* polish code
ver217 pushed a commit to ver217/ColossalAI that referenced this pull request Jul 13, 2023
* allow passing process group to zero12

* union tp-zero and normal-zero

* polish code
kurisusnowdeng pushed a commit to kurisusnowdeng/ColossalAI that referenced this pull request Jul 25, 2023
* allow passing process group to zero12

* union tp-zero and normal-zero

* polish code
ver217 pushed a commit that referenced this pull request Jul 31, 2023
* allow passing process group to zero12

* union tp-zero and normal-zero

* polish code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API related to API changes compatibility related to compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[zero] pass process_group for low level zero
3 participants