-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[zero] allow passing process group to zero12 #4153
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankLeeeee
reviewed
Jul 4, 2023
ver217
reviewed
Jul 4, 2023
The code coverage for the changed files is 86%. Click me to view the complete report
|
kurisusnowdeng
pushed a commit
to kurisusnowdeng/ColossalAI
that referenced
this pull request
Jul 10, 2023
* allow passing process group to zero12 * union tp-zero and normal-zero * polish code
kurisusnowdeng
pushed a commit
to kurisusnowdeng/ColossalAI
that referenced
this pull request
Jul 12, 2023
* allow passing process group to zero12 * union tp-zero and normal-zero * polish code
kurisusnowdeng
pushed a commit
to kurisusnowdeng/ColossalAI
that referenced
this pull request
Jul 12, 2023
* allow passing process group to zero12 * union tp-zero and normal-zero * polish code
ver217
pushed a commit
to ver217/ColossalAI
that referenced
this pull request
Jul 13, 2023
* allow passing process group to zero12 * union tp-zero and normal-zero * polish code
kurisusnowdeng
pushed a commit
to kurisusnowdeng/ColossalAI
that referenced
this pull request
Jul 25, 2023
* allow passing process group to zero12 * union tp-zero and normal-zero * polish code
ver217
pushed a commit
that referenced
this pull request
Jul 31, 2023
* allow passing process group to zero12 * union tp-zero and normal-zero * polish code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Checklist before creating the PR
[doc/gemini/tensor/...]: A concise description
🚨 Issue number
fixed #4151
📝 What does this PR do?
This PR support passing dp and tp process_group to low_level_zero, which further supports the new processGroupMesh.
💥 Checklist before requesting a review
⭐️ Do you enjoy contributing to Colossal-AI?
Tell us more if you don't enjoy contributing to Colossal-AI.