Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shardformer] Change atol in test command-r weight-check to pass 8GPU pytest #5835

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

GuangyaoZhang
Copy link
Contributor

@GuangyaoZhang GuangyaoZhang commented Jun 19, 2024

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs
  • I have installed pre-commit: pip install pre-commit && pre-commit install

🚨 Issue number

resolved #5834

📝 What does this PR do?

Change atol in test command-r weight-check to pass 8 GPU pytest

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@GuangyaoZhang GuangyaoZhang requested a review from a team as a code owner June 19, 2024 04:55
@GuangyaoZhang GuangyaoZhang changed the title [shardformer] Change atol in test command-r weight-check to pass pytest [shardformer] Change atol in test command-r weight-check to pass 8GPU pytest Jun 19, 2024
@ver217 ver217 merged commit fd1dc41 into hpcaitech:main Jun 19, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Command-R 8 GPU Pytest failure
2 participants