Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JAPI-116 Expose filespray options #211

Merged
merged 1 commit into from
Oct 24, 2018
Merged

JAPI-116 Expose filespray options #211

merged 1 commit into from
Oct 24, 2018

Conversation

rpastrana
Copy link
Member

@rpastrana rpastrana commented Oct 24, 2018 •
edited
Loading

  • Exposes more filespray options in FileSprayclient
  • Updates filespray interface stub

Signed-off-by: Rodrigo Pastrana rodrigo.pastrana@lexisnexis.com

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change is a breaking change (fix or feature that will cause existing behavior to change).

Checklist:

  • I have created a corresponding JIRA ticket for this submission
  • My code follows the code style of this project.
    • I have applied the Eclipse code-format template provided.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the HPCC Systems CONTRIBUTORS document (https://github.com/hpcc-systems/HPCC-Platform/wiki/Guide-for-contributors).
  • The change has been fully tested:
    • I have performed unit tests to cover my changes.
    • I have performed system test and covered possible regressions and side effects.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.

Testing:

@rpastrana
JAPI-116 Expose filespray options
9b31850 
- Exposes more filespray options in FileSprayclient
- Updates filespray interface stub

Signed-off-by: Rodrigo Pastrana <rodrigo.pastrana@lexisnexis.com>
@rpastrana
Copy link
Member Author

code reviewed here: #210

@rpastrana rpastrana merged commit 99e227b into hpcc-systems:master Oct 24, 2018
woodbr01 pushed a commit to woodbr01/HPCC-JAPIs that referenced this pull request Feb 7, 2020
@rpastrana
JAPI-116 Expose filespray options (hpcc-systems#211)
4536817 
- Exposes more filespray options in FileSprayclient
- Updates filespray interface stub

Signed-off-by: Rodrigo Pastrana <rodrigo.pastrana@lexisnexis.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rpastrana