ML-421 Remove Typedef from MakeR8Set in PBblas #12
Conversation
|
@johnholt Please review |
internal/MakeR8Set.ecl
Outdated
| } pbb_cell; | ||
| #endif // pbb_cell #ifndef pbb_cell | ||
|
|
||
| struct __attribute__ ((__packed__)) pbb_cell{ |
There was a problem hiding this comment.
I am not an expert at C++ but I am under the impression that the struct declaration should be wrapped with an if not defined (#ifndef FOO and #define FOO). If this structure is used (and it could be in my opinion) by another BEGINC++ attribute, then you could get a multiple defined name. @richardkchapman should correct me if multiple definitions of the same struct are OK.
There was a problem hiding this comment.
I would have thought simply removing the #body on line 35 (meaning that the struct definition would be local to the generated function) would be the simplest and cleanest way to avoid that potential issue.
There was a problem hiding this comment.
Sounds OK to me, but I don't have exact knowledge of the visibility rules for the modern version of the C++ language.
Remove typedef and re-test Remove #body tag per code review Signed-off-by: Roger Dev <Roger.Dev@LexisNexisRisk.com>
Remove typedef and re-test
Signed-off-by: Roger Dev Roger.Dev@LexisNexisRisk.com