Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Axis): Add label / icon mapping #3595

Merged
merged 1 commit into from
May 14, 2020
Merged

feat(Axis): Add label / icon mapping #3595

merged 1 commit into from
May 14, 2020

Conversation

GordonSmith
Copy link
Member

@GordonSmith GordonSmith commented May 13, 2020 •
edited
Loading

Signed-off-by: Gordon Smith GordonJSmith@gmail.com

Checklist:

  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit message includes a "fixes" reference if appropriate.
    • The commit is signed.
  • The change has been fully tested:
    • I have viewed all related gallery items
    • I have viewed all related dermatology items
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised new issues to address them separately

Testing:

jbrundage
jbrundage reviewed May 13, 2020
View reviewed changes
Copy link
Contributor

@jbrundage jbrundage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We link to "samples/chart/Bar.js" in the chart README.md

@GordonSmith
feat(Axis): Add label / icon mapping
259c06a 
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
@GordonSmith
Copy link
Member Author

@jbrundage good catch - updated ref URL

@GordonSmith GordonSmith merged commit 0d04236 into hpcc-systems:master May 14, 2020
@GordonSmith GordonSmith deleted the ICON_PALETTE branch May 14, 2020 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrundage jbrundage jbrundage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GordonSmith @jbrundage