Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JAPI-119 Moved versioning for wsclient to parallel platform #201

Merged
merged 1 commit into from
Aug 15, 2018

Conversation

Michael-Gardner
Copy link
Contributor

@Michael-Gardner Michael-Gardner commented Aug 15, 2018

Signed-off-by: Michael Gardner michael.gardner@lexisnexisrisk.com

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change is a breaking change (fix or feature that will cause existing behavior to change).

Checklist:

  • I have created a corresponding JIRA ticket for this submission
  • My code follows the code style of this project.
    • I have applied the Eclipse code-format template provided.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the HPCC Systems CONTRIBUTORS document (https://github.com/hpcc-systems/HPCC-Platform/wiki/Guide-for-contributors).
  • The change has been fully tested:
    • I have performed unit tests to cover my changes.
    • I have performed system test and covered possible regressions and side effects.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.

Testing:

@Michael-Gardner
Copy link
Contributor Author

@rpastrana Please give this a quick check

@@ -44,6 +44,11 @@ wsclient | hpccsystems-platform
#### Future Release

###### 7.0.0 Target Release date September, 2018
- JAPI-119 Moving the versioning system for wsclient to parallel supported versions of the platform
- JAPI-112 Provide 7.0.0 platform interfaces
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's remove this one in favor of JAPI-126

- JAPI-112 Provide 7.0.0 platform interfaces
- JAPI-109 File structure info
- JAPI-118 Address missing DFUFileDetail Field
- JAPI-126 Update HPCC 7.0.0 ESP interfaces
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add to this description ... " and remove interfaces pre HPCC 6.0.0" or something similar to that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

K.

Copy link
Member

@rpastrana rpastrana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Michael-Gardner just a couple of comments

Signed-off-by: Michael Gardner <michael.gardner@lexisnexisrisk.com>
Copy link
Member

@rpastrana rpastrana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Michael-Gardner Michael-Gardner merged commit 47e6394 into hpcc-systems:master Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants