Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a regression introduced by #6008 adding bind mounts without destination two times #6166

Merged
merged 1 commit into from
Sep 4, 2021

Conversation

cclerget
Copy link
Collaborator

@cclerget cclerget commented Sep 4, 2021

Description of the Pull Request (PR):

Due to a logic error introduced by #6008, a bind mount without destination is added two times and display a warning telling that the destination mount point was previously added. The bind mount works as expected but display a false warning.

This fixes or addresses the following GitHub issues:

@cclerget cclerget added the Regression Issues which describes regressions in Singularity label Sep 4, 2021
@cclerget cclerget self-assigned this Sep 4, 2021
@cclerget cclerget added the ci:e2e label Sep 4, 2021
@DrDaveD DrDaveD merged commit 5bdf679 into apptainer:master Sep 4, 2021
@DrDaveD DrDaveD added this to the 3.8.3 milestone Sep 4, 2021
@gmkurtzer
Copy link
Contributor

Looks good, thank you @cclerget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:e2e Regression Issues which describes regressions in Singularity
Projects
None yet
3 participants