PackedBinary tries to copy sources to installdir even if buildininstalldir = True

[pescobar]

While writting a new easyconfig I got this error:

  File "/usr/lib64/python2.6/shutil.py", line 48, in copyfile
    raise Error("`%s` and `%s` are the same file" % (src, dst))

My guess is that when using the PackedBinary easyblock and the option buildininstalldir = True easybuild still tries to copy the sources (which are already in the installdir) to the installdir again

This test (non working) easyconfig can be used to reproduce the error:
https://gist.github.com/c97a74b0a2f6f07f115ec977a7225dbd

this is the debug log:
https://gist.github.com/9e3d809883d065b7c69b2379a86ba920

by now, what I have done to workaround the problem is to use this install_cmd:

install_cmd = 'mkdir -p %(installdir)s && '
install_cmd += 'cp -r * %(installdir)s && '
install_cmd += 'cd %(installdir)s/ && '
install_cmd += 'make pcrclipreads'

My first test was to do only this as install_cmd (which triggers the error)

buildininstalldir = True
install_cmd = 'make pcrclipreads'

[pescobar]

Another approach is to use the ConfigureMake easyblock where the buildininstalldir = True works fine. See easybuilders/easybuild-easyconfigs#4262

[boegel]

@pescobar I'd say it doesn't make much sense to use buildininstalldir = True together with PackedBinary...

You could also have run make pcrclipreads via postinstallcmds?

Maybe this is just a matter of making the error message clearer?

[pescobar]

@boegel I would expect that if I use buildininstalldir = True the sources are not copied again from builddir to installdir because both are the same.

I noticed the issue while using packedbinary but IMHO this should be the case no matter what easyblock is used.