Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ported easyblocks for picard and GenomeAnalysisTK #278

Merged
merged 1 commit into from Nov 13, 2013

Conversation

boegel
Copy link
Member

@boegel boegel commented Oct 16, 2013

No description provided.

@JensTimmerman
Copy link
Contributor

test this please

@boegel
Copy link
Member Author

boegel commented Nov 9, 2013

@JensTimmerman: please review this so it's eligible for merging in


from easybuild.framework.easyblock import EasyBlock


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed, all fine, simply remove the extra line above if considered redundant

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there should be two empty lines above the class definition :)

@boegel
Copy link
Member Author

boegel commented Nov 13, 2013

Thanks for the review @fgeorgatos!

boegel added a commit that referenced this pull request Nov 13, 2013
add ported easyblocks for picard and GenomeAnalysisTK
@boegel boegel merged commit 7355b02 into easybuilders:develop Nov 13, 2013
@boegel boegel deleted the picard_GATK branch November 13, 2013 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants