correctly disable parallel build for ATLAS #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if not nr: | ||
| self.log.warning("Ignoring requested parallelism, it breaks ATLAS, so setting to 1") | ||
| if self.cfg['parallel'] != 1: | ||
| self.log.warning("Ignoring requested build parallelism, it breaks ATLAS, so setting to 1") | ||
| self.log.info("Disabling parallel build, makes no sense for ATLAS.") |
There was a problem hiding this comment.
This message makes no sense 😉
Just drop it? if the parallel is already on 1, there is no issue. Only display the warning when it is needed?
|
@wpoely86: fixed, pls recheck? |
|
@boegel Looks good |
|
Thanks for the review @wpoely86! |
boegel
added a commit
that referenced
this pull request
Jul 8, 2014
correctly disable parallel build for ATLAS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
set_parallellismmethod is moved and renamed as a part of easybuilders/easybuild-framework#953, since it's not considered to be part of the easyblocks APIThis patch tweaks the ATLAS easyblock to properly disable a parallel build.