-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance WIEN2k easyblock for recent versions + cleanup #486
Conversation
Added support for wien2k 13/14 as well as added extra configuration options for the parallel_options file.
The directory defaults to $TMPDIR if set else /tmp, if the directory doesn't exist it is created. An alternative would be to just use the same temp dir as for the calculation.
Test PASSed. |
@wpoely86, @JensTimmerman: please review? |
('use_remote', [True, "Whether to remotely login to initiate the k-point parallellization calls", CUSTOM]), | ||
('mpi_remote', [False, "Whether to initiate MPI calls locally or remotely", CUSTOM]), | ||
('wien_granularity', [True, "Granularity for parallel execution (see manual)", CUSTOM]), | ||
('taskset', ['no', "Specifies an optional command for binding a process to a specific core", CUSTOM]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not None
by default?
Looks fine |
Test PASSed. |
@wpoely86: remark fixed, please check again since I did some cleanup changes w.r.t. patching |
Looks fine? |
Test PASSed. |
Test PASSed. |
Conflicts: easybuild/easyblocks/w/wien2k.py
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Tested with easyconfigs in easybuilders/easybuild-easyconfigs#1130 (see https://gist.github.com/98d5c5192327aefc2e1a, looking great now. Thanks for initiating this @MichaelSluydts! |
enhance WIEN2k easyblock for recent versions + cleanup
This builds on top of #479 by @MichaelSluydts