Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance WIEN2k easyblock for recent versions + cleanup #486

Merged
merged 15 commits into from
Apr 9, 2015

Conversation

boegel
Copy link
Member

@boegel boegel commented Oct 9, 2014

This builds on top of #479 by @MichaelSluydts

MichaelSluydts and others added 9 commits September 26, 2014 15:10
Added support for wien2k 13/14 as well as added extra configuration options for the parallel_options file.
The directory defaults to $TMPDIR if set else /tmp, if the directory doesn't exist it is created. An alternative would be to just use the same temp dir as for the calculation.
@boegel boegel changed the title enhance WIEN2k for recent versions + cleanup enhance WIEN2k easyblock for recent versions + cleanup Oct 9, 2014
@hpcugentbot
Copy link
Contributor

Test PASSed.

@boegel
Copy link
Member Author

boegel commented Oct 9, 2014

@wpoely86, @JensTimmerman: please review?

('use_remote', [True, "Whether to remotely login to initiate the k-point parallellization calls", CUSTOM]),
('mpi_remote', [False, "Whether to initiate MPI calls locally or remotely", CUSTOM]),
('wien_granularity', [True, "Granularity for parallel execution (see manual)", CUSTOM]),
('taskset', ['no', "Specifies an optional command for binding a process to a specific core", CUSTOM]),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not None by default?

@wpoely86
Copy link
Member

wpoely86 commented Oct 9, 2014

Looks fine

@hpcugentbot
Copy link
Contributor

Test PASSed.

@boegel
Copy link
Member Author

boegel commented Oct 9, 2014

@wpoely86: remark fixed, please check again since I did some cleanup changes w.r.t. patching parallel_options

@wpoely86
Copy link
Member

wpoely86 commented Oct 9, 2014

Looks fine?

@hpcugentbot
Copy link
Contributor

Test PASSed.

@hpcugentbot
Copy link
Contributor

Test PASSed.

Conflicts:
	easybuild/easyblocks/w/wien2k.py
@hpcugentbot
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/905/
Test FAILed.

@hpcugentbot
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/906/
Test PASSed.

@boegel
Copy link
Member Author

boegel commented Apr 9, 2015

Tested with easyconfigs in easybuilders/easybuild-easyconfigs#1130 (see https://gist.github.com/98d5c5192327aefc2e1a, looking great now.

Thanks for initiating this @MichaelSluydts!
Thanks for the review @wpoely86!

boegel added a commit that referenced this pull request Apr 9, 2015
enhance WIEN2k easyblock for recent versions + cleanup
@boegel boegel merged commit 3124163 into easybuilders:develop Apr 9, 2015
@boegel boegel deleted the wien2k branch April 9, 2015 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants