relocate FDTD RPM to fix installation on SL6 #538
Conversation
|
Test PASSed. |
| @@ -40,7 +44,23 @@ def configure_step(self): | |||
|
|
|||
| def build_step(self): | |||
| """No build step for FDTD Solutions.""" | |||
| pass | |||
| # locate RPM and rebuild it to make it relocatable | |||
| rpms = glob.glob(os.path.join(self.cfg['start_dir'], 'rpm_install_files', 'FDTD-%s*.rpm' % self.version)) | |||
There was a problem hiding this comment.
any particular reason why you need glob here? There is a 'random' part in the filename?
There was a problem hiding this comment.
I just don't want to make any assumptions here. In the versions I've tested have 'el5' in them, but I don't think that's a safe assumption to make for future versions.
|
ok |
| self.log.error("Incorrect number of rebuilt RPMs found, was expecting exactly one: %s" % rebuilt_rpms) | ||
|
|
||
| try: | ||
| os.rename(rpms[0], '%s.bk' % rpms[0]) |
There was a problem hiding this comment.
why renamed? We're not going to use the original one anymore?
There was a problem hiding this comment.
mostly for debugging purposes, this will be cleaned up once the installation succeeds anyway
|
Test PASSed. |
|
fixes the FDTD build, see easybuilders/easybuild-easyconfigs#1307 also verified that this doesn't break the installation of QLogicMPI, which relies on the so, going in, thanks for the thorough review @wpoely86! |
relocate FDTD RPM to fix installation on SL6
This fixes easybuilders/easybuild-easyconfigs#640
@wpoely86: please review?