drop -noroot for recent FLUENT versions, honor installopts, enable -debug #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Refer to this link for build results (access rights to CI server needed): |
| if LooseVersion(self.version) < LooseVersion('15.0'): | ||
| extra_args += '-noroot' | ||
|
|
||
| cmd = "./INSTALL %s -debug -silent -install_dir %s %s" % (extra_args, self.installdir, self.cfg['installopts']) |
There was a problem hiding this comment.
doesn't hurt, I guess
the real solution for large (debug) logs is supporting automatically zipping them at the end of the installation ;)
There was a problem hiding this comment.
debug refers too the install process or the actual application being installed?
|
retested with all existing FLUENT easyconfigs, nothing was broken, so going in Thanks for the review @wpoely86! |
boegel
added a commit
that referenced
this pull request
Mar 19, 2015
drop -noroot for recent FLUENT versions, honor installopts, enable -debug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@wpoely86: please review, well (re)test all existing FLUENT easyconfigs with this in place