Update CPLEX easyblock #797
Conversation
sbecuwe
commented
Jan 5, 2016
sbecuwe
commented
- added extra PATHs
- added LD_LIBRARY_PATH
- added CPLEXDIR (as used in the Makefiles)
- added extra PATHs - added LD_LIBRARY_PATH - added CPLEXDIR (as used in the Makefiles)
|
Automatic reply from Jenkins: Can I test this? |
| binglob = '*/bin/x86-64*' | ||
| bins = glob.glob(binglob) | ||
| libglob = '*/lib/x86-64*/*pic' | ||
| libs = glob.glob(libglob) |
There was a problem hiding this comment.
this should be wrapped in a try:/except OSError?
There was a problem hiding this comment.
No. If it's empty, it is. It's actually tested in the post_install_step.
|
Jenkins: ok to test |
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1557/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
- rewritten glob construction using os.path.join - simplified LD_LIBRARY_PATH line
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1558/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
fix remarks w.r.t. using glob in installdir
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1573/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
tested with existing CPLEX easyconfigs and easybuilders/easybuild-easyconfigs#2259, good to go Thanks @sbecuwe! |
