New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenFOAM with extranal cgal, metis, and paraview, with deps using intel2... #1166
Conversation
Automatic reply from Jenkins: Can I test this? |
Jenkins: ok to test |
Test FAILed. |
Test FAILed. |
1 similar comment
Test FAILed. |
Jenkins: test this please |
Refer to this link for build results (access rights to CI server needed): This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
@@ -0,0 +1,23 @@ | |||
name = 'METIS' | |||
version = '5.1.0' | |||
versionsuffix = '-32bitIDX' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you clarify this versionsuffix?
The only 'special' thing I see in here is that the METIS shared libs get built?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
boegel: Well, the other special thing is the absence of the METIS_IDXTYPEWIDTH.patch
For some reason OpenFOAM 2.3.0
needs 32 bit index, probably beacuse it uses fortran code. Instead of patching OpenFOAM
, I made the 32bit index version of METIS
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that explains it.
Maybe add a comment right above the versionsuffix to clarify that? Something like "default 32-bit IDTYPEWIDTH, no patch used" ?
Test report by @boegel |
…syconfigs into openfoam-intel2014b
@boegel: Comment forom CGAL removed |
Refer to this link for build results (access rights to CI server needed): This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
Refer to this link for build results (access rights to CI server needed): This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
Jenkins: test this please |
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4409/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
description = "Paraview is a scientific parallel visualizer" | ||
|
||
toolchain = {'name': 'intel', 'version': '2014b'} | ||
toolchainopts = {'usempi': False, 'pic': True} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not have a mesa dependency, but it should have a mesa osdependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see #1618
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added old style mesa (10.4.5) with osdependencies = [
'libX11-devel', # Xlibs.h
'xorg-x11-proto-devel', # X.h, glproto, xproto
'libXdamage-devel',
'libXext-devel',
'libXfixes-devel',
]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a la. PR #1439
…nto openfoam-intel2014b
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4428/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
] | ||
|
||
builddeps = [ | ||
('CMake', '3.0.0'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
upgrade to 3.1.0
General remark: create a Autotools easyconfig version with what you need and use that everywhere instead of the individual tools. |
Test report by @wpoely86 |
We have started to use autotools from 2015a toolchains. Should I change PR to autotools? And if Yes, which version? |
I would do that yes. Pick the latest version and change the toolchain version accordingly. |
configopts = '--enable-nouveau-experimental-api' removed from libdrm (all versions) |
|
||
dependencies = [ | ||
('Qt','4.8.6'), | ||
('Mesa', '10.4.5', '-Python-2.7.8'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't it be better go with 10.5.5 from #1618, and drop the Mesa-related stuff in this PR?
I'm not very keen on having lots of Mesa easyconfigs around, since they have a huge number of deps...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or we can promote this to 2015a?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@boegel: yeah, I already started to make this with 2015a, but I have never finished. Either the PR is too big, or it has lots of deps. I would like to finish this as it is, or abandon this PR and finish 2015a vesrion (which should also be bumped to 2015b, and OpenFOAM bumped to 2.4.X), and honestly this OpenFOAM feels for me a never ending story.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OK with abandoning this in favor of a 2015a or 2015b effort (the latter implies also redoing Mesa with 2015b...)
It's important to keep PRs somewhat minimal; this PR already throws a whole bunch of things together (see the libdrm and libxml2 changes).
Paraview should be handled in a separate PR for example, not involving OpenFOAM
if remarks are made to an easyconfig that should be fixed in all existing easyconfigs for that software (cfr. libdrm) handle that in a separate PR too (to avoid blocking this PR for it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I will flesh out libdrm and libxml2 from this pr. and close this one. This means that OpenFOAM external will not be in this sprint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the sprint is more intended for 'low-hanging fruit', I wouldn't call a PR with 50+ touched files that ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, originally it was much less. And I meat OpenFOAM with 2015a
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4456/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
...014b
Needs
easybuilders/easybuild-easyblocks#494and easybuilders/easybuild-easyblocks#497 QT is in#1079