Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{toolchains} add [Clang/3.6.0] and deps, and toolchains above it, aligned with goolf/1.7.20 (REVIEW) #1410

Closed

Conversation

fgeorgatos
Copy link
Contributor

This builds upon #1389 for the upcoming Clang/3.6.0 , 21 Feb. 2015, as per http://llvm.org
At moment of PR initiation, toolchains up to cgmvapich2 are included and more to be added asap.
It is aligned to recent toolchains #1294 & #1397 and features similar compatibility aspects.

@hpcugentbot
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/2366/
Test PASSed.

easyblock = 'ConfigureMake'

name = 'Bison'
version = '2.7'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not 3.0.4?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather avoid version creep unless there is a known benefit, no? (yeah, we still luck a rule in this)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this Bison easyconfig is needed as a dep for the MVAPICH2 easyconfig, the existing MVAPICH2 easyconfig for the same version already uses Bison 2.7, so it makes sense to stick to this version

the only real solution for this version madness is supporting open-ended version specs (which is a whole new league of pain by itself, imho)

@boegel
Copy link
Member

boegel commented Feb 18, 2015

@fgeorgatos: please mark this as (WIP), since the official Clang version 3.6.0 is not available yet...

@boegel
Copy link
Member

boegel commented Mar 6, 2015

@fgeorgatos: please sync this up with the Clang easyconfig in #1389

The window for EB v2.0 is closed though, sorry.

@fgeorgatos fgeorgatos changed the title {toolchains} add [Clang/3.6.0] and deps, and toolchains above it, aligned with goolf/1.7.20 {toolchains} add [Clang/3.6.0] and deps, and toolchains above it, aligned with goolf/1.7.20 (WIP) Mar 16, 2015
@hpcugentbot
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/2606/
Test PASSed.

@hpcugentbot
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/2607/
Test PASSed.

@boegel
Copy link
Member

boegel commented Mar 16, 2015

@fgeorgatos: let me know when you consider this ready...

@fgeorgatos
Copy link
Contributor Author

fyi. this is still WIP

##

name = "Clang"
version = "3.6.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upgrade to 3.6.1?

@fgeorgatos fgeorgatos changed the title {toolchains} add [Clang/3.6.0] and deps, and toolchains above it, aligned with goolf/1.7.20 (WIP) {toolchains} add [Clang/3.6.0] and deps, and toolchains above it, aligned with goolf/1.7.20 (REVIEW) Sep 19, 2016
@fgeorgatos
Copy link
Contributor Author

i'm converting this to REVIEW status, since the only comment it picked up was for a minor bump.

btw.
synchronizing to #1389 would have the undesired effect of pulling this away from being compatible to goolf/1.7.20, which was the desired objective to have this in the first place!

@fgeorgatos
Copy link
Contributor Author

@boegel: could we put milestone here to 2.9.0, if this is interesting?
n.b. this becomes more interesting now due to possible deprecation of other cgoolf examples.

@boegel
Copy link
Member

boegel commented Sep 20, 2016

(close/open to trigger Travis)

@boegel boegel closed this Sep 20, 2016
@boegel boegel reopened this Sep 20, 2016
@boegel boegel added this to the v2.9.0 milestone Sep 20, 2016
@boegel
Copy link
Member

boegel commented Sep 20, 2016

@fgeorgatos I'll consider it for v2.9.0, let's see how the tests work out

@boegel
Copy link
Member

boegel commented Sep 20, 2016

@fgeorgatos please review/merge the fixes in fgeorgatos#40

@boegel
Copy link
Member

boegel commented Sep 20, 2016

Test report by @boegel
FAILED
Build succeeded for 6 out of 12 (9 easyconfigs in this PR)
node1188.muk.os - Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/0f777d40c402183d4529ceed577eeb27 for a full test report.

@boegel
Copy link
Member

boegel commented Sep 20, 2016

@fgeorgatos Clang 3.6.0 requires Python 2.7.x as build dep...

Adding that brings in a whole bunch of other easyconfigs, for Python 2.7.x with the GCC/4.8.4 toolchain. Do we want to go down that road?

@fgeorgatos
Copy link
Contributor Author

@boegel: i'd say let's not go with Python as a dep unless there is strong objection:
IMHO, keeping it as a simple reference, so that --try-toolchain=cgmvapich2,1.7.20 is probably all that is needed.

@boegel
Copy link
Member

boegel commented Sep 20, 2016

@fgeorgatos note that we're talking Python 2.7.x as a build dep of Clang here, so it would have no impact on --try-toolchain

If we don't include as a dep (like we did in #1389), building Clang will not work on a system where Python is < 2.7...

@boegel
Copy link
Member

boegel commented Sep 20, 2016

@fgeorgatos please merge fgeorgatos#41 to fix the conflict and add the missing build deps (taken care of via #3586)

add missing build dep for Clang 3.6.0 + remove duplicate GMP easyconfig
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Sep 21, 2016

Test report by @boegel
FAILED
Build succeeded for 9 out of 11 (8 easyconfigs in this PR)
node2606.swalot.os - Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/768b3a20872aea84ebe2e60cc177800d for a full test report.

@boegel
Copy link
Member

boegel commented Sep 21, 2016

Test report by @boegel
FAILED
Build succeeded for 6 out of 8 (8 easyconfigs in this PR)
node2025.delcatty.os - Linux SL 6.8, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/6f19ef4dfc30b407e4fad0141c8334ac for a full test report.

@boegel
Copy link
Member

boegel commented Sep 21, 2016

@fgeorgatos compilation failure of MVAPICH2 v2.0.1 with this version of ClangGCC... did this work for you?

Also, we should add an HPL easyconfig using this toolchain as a test case...

@boegel boegel modified the milestones: v2.x, v2.9.0 Sep 22, 2016
@boegel boegel modified the milestones: 3.0, v2.x Oct 28, 2016
@boegel boegel modified the milestones: v3.x, 3.0 Nov 15, 2016
@migueldiascosta
Copy link
Member

@fgeorgatos, this PR is being closed for the following reason(s): no activity for > 6 months.
Please don't hesitate to reopen this PR or add a comment if you feel this contribution is still relevant.
For more information on our policy w.r.t. closing PRs, see https://easybuild.readthedocs.io/en/latest/Contributing.html#why-a-pull-request-may-be-closed-by-a-maintainer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants