Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{cae} [intel-2015a] GATE-7.0, Geant4-9.6.p04, root-5.34.26, clhep-2.1.3.1 (REVIEW) #1439

Merged
merged 27 commits into from Jan 12, 2016

Conversation

hajgato
Copy link
Collaborator

@hajgato hajgato commented Mar 3, 2015

@hpcugentbot
Copy link
Contributor

Automatic reply from Jenkins: Can I test this?

@boegel
Copy link
Member

boegel commented Mar 3, 2015

Jenkins: ok to test

@hpcugentbot
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/2453/
Test FAILed.

@hajgato hajgato changed the title {cae} [intel-2015a] GATE-7.0, Geant4-9.6.p04, root-5.34.25, clhep-2.1.3.1 (WIP) {cae} [intel-2015a] GATE-7.0, Geant4-9.6.p04, root-5.34.25, clhep-2.1.3.1 (REVIEW) Mar 4, 2015
@hpcugentbot
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/2460/
Test FAILed.

@hajgato
Copy link
Collaborator Author

hajgato commented Mar 4, 2015

Gate should be build using gate.py easyblock. Still, Jenkins want to fall back to ConfigureMake. Why?

@boegel
Copy link
Member

boegel commented Mar 4, 2015

@hajgato: GATE-7.0-intel-2015b.eb is empty, which is confusing the tests...

@hajgato
Copy link
Collaborator Author

hajgato commented Mar 4, 2015

Oops...

@hpcugentbot
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/2462/
Test FAILed.

@hpcugentbot
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/2463/
Test PASSed.

@hajgato hajgato changed the title {cae} [intel-2015a] GATE-7.0, Geant4-9.6.p04, root-5.34.25, clhep-2.1.3.1 (REVIEW) {cae} [intel-2015a] GATE-7.0, Geant4-9.6.p04, root-5.34.26, clhep-2.1.3.1 (REVIEW) Mar 4, 2015
@hajgato
Copy link
Collaborator Author

hajgato commented Mar 4, 2015

Jenkins approved

@hpcugentbot
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/2466/
Test PASSed.

@boegel
Copy link
Member

boegel commented Mar 4, 2015

@hajgato: this PR is quite big, so it's going to be a pain to get it tested/reviewed/merged...

Are you up for submitting a test report for this? See https://github.com/hpcugent/easybuild/wiki/Review-process-for-contributions#automated-testing-of-easyconfigs-pull-requests

@hajgato
Copy link
Collaborator Author

hajgato commented Mar 4, 2015

@boegel: Sorry for that, It was not the intention. I had no idea that ROOT has so many dependencies. And I did not even included graphviz, that would be 15+ more deps. :(

For some reason, I am not able to automatically upload gist from our machine using --upload-test-report, and actually I am not able to upload any gists at all (some ssh incompatibility error.) If you tell me I can upload manually the test reports. (Or alternatively, I can test it from my desktop)

@hajgato
Copy link
Collaborator Author

hajgato commented Mar 4, 2015

@boegel: Or should I cut this pr into parts?

@boegel
Copy link
Member

boegel commented Mar 4, 2015

@hajgato: let's first see how painful this is, before we cut it into pieces, we can still do that later

# build dir should not be in the source tree!
preconfigopts = 'mkdir ../../2.1.3.1_bld && cd ../../2.1.3.1_bld &&'
prebuildopts = 'cd ../../2.1.3.1_bld &&'
preinstallopts = 'cd ../../2.1.3.1_bld &&'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't hardcode the version, and there's even no need to use the version at all?

just call the dir obj, which is more-or-less a standard?

@boegel
Copy link
Member

boegel commented Mar 4, 2015

@hajgato: I'd like to see Mesa handled separately, preferably via the approach done in #1226 (i.e. without any OS deps); sadly, #1226 never got finished... :(

@hajgato
Copy link
Collaborator Author

hajgato commented Mar 5, 2015

@boegel what about eudev? That provides the libudev. (needs kernel headers, though) see http://www.gentoo.org/proj/en/eudev/

@hpcugentbot
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/2473/
Test PASSed.

@boegel boegel modified the milestones: v2.6.0, v2.5.0 Dec 14, 2015
@boegel
Copy link
Member

boegel commented Jan 9, 2016

Jenkins: test this please

@boegel
Copy link
Member

boegel commented Jan 9, 2016

@hajgato: Jenkins/GitHub is confused about this, probably due to temporary issues with Jenkins at the time of the test

can you sync this with develop to try and get Jenkins to give a green light?

@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5553/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Member

boegel commented Jan 10, 2016

Test report by @boegel
FAILED
Build succeeded for 16 out of 19 (19 easyconfigs in this PR)
Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/c6112ca4019d71910010 for a full test report.

@boegel
Copy link
Member

boegel commented Jan 10, 2016

@hajgato: failed test report due to download failures, I'll handle them and submit a new test report

@boegel
Copy link
Member

boegel commented Jan 10, 2016

Test report by @boegel
SUCCESS
Build succeeded for 19 out of 19 (19 easyconfigs in this PR)
Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/f3b40faa4985daecd0fa for a full test report.

ext_bldd = '../../builddir'
preconfigopts = 'mkdir %s && cd %s &&' % (ext_bldd,ext_bldd)
prebuildopts = 'cd %s &&' % ext_bldd
preinstallopts = 'cd %s &&' % ext_bldd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMakeMake (now) supports separate_build_dir = True, so just use that?

@boegel
Copy link
Member

boegel commented Jan 10, 2016

@hajgato: some minor style remarks left, let's get this merged... Let me know if you're sick of tackling remarks on this one, I can take it from here if you want me to. :-)

@hajgato
Copy link
Collaborator Author

hajgato commented Jan 12, 2016

@boegel: all changes implemented

@boegel
Copy link
Member

boegel commented Jan 12, 2016

lgtm

@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5624/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

prebuildopts = 'CPATH="$EBROOTLIBDRM/include/libdrm" '

sanity_check_paths = {
'files': ['lib/libGL.%s' % SHLIB.EXT, 'include/GL/glext.h', 'include/GL/gl_mangle.h',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/SHLIB.EXT/SHLIB_EXT/g

@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5626/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Member

boegel commented Jan 12, 2016

Test report by @boegel
SUCCESS
Build succeeded for 19 out of 19 (19 easyconfigs in this PR)
Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/d76b5fa2d51a94b8944d for a full test report.

@boegel
Copy link
Member

boegel commented Jan 12, 2016

(finally) going in, thanks @hajgato!

boegel added a commit that referenced this pull request Jan 12, 2016
{cae} [intel-2015a] GATE-7.0, Geant4-9.6.p04, root-5.34.26, clhep-2.1.3.1 (REVIEW)
@boegel boegel merged commit 2340562 into easybuilders:develop Jan 12, 2016
@hajgato hajgato deleted the gate7 branch June 8, 2017 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants