-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fixes: add sanity check to GEOS and change homepage netcdf4-python #2285
Conversation
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5501/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
sources = [SOURCELOWER_TAR_BZ2] | ||
|
||
toolchain = {'name': 'goalf', 'version': '1.1.0-no-OFED'} | ||
|
||
sanity_check_paths = { | ||
'files': ['bin/geos-config', 'lib/libgeos.so', 'lib/libgeos.a', 'include/geos.h'], | ||
'dirs': ["."] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change this to empty list please, .
will always be a non-empty dir
and make the title a bit more descriptive, otherwise it'll be a nuisance when composing the release notes |
Test report by @wpoely86 |
@@ -4,11 +4,16 @@ name = 'GEOS' | |||
version = '3.3.5' | |||
|
|||
homepage = 'http://trac.osgeo.org/geos' | |||
description = """GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite (JTS)""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing """
in front, syntax error
Test report by @wpoely86 |
Test report by @boegel |
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5504/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5508/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
going in, thanks @wpoely86! |
Various fixes: add sanity check to GEOS and change homepage netcdf4-python
As requested in #2221