Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib FFTW/2.1.5 and improve sources directive where needed #247

Merged
merged 18 commits into from May 22, 2013

Conversation

fgeorgatos
Copy link
Contributor

To replace #123 in a more clean PR.

… apps

Signed-off-by: Fotis Georgatos <fotis.georgatos@uni.lu>
Signed-off-by: Fotis Georgatos <fotis.georgatos@uni.lu>
Signed-off-by: Fotis Georgatos <fotis.georgatos@uni.lu>
Signed-off-by: Fotis Georgatos <fotis.georgatos@uni.lu>
Signed-off-by: Fotis Georgatos <fotis.georgatos@uni.lu>
Signed-off-by: Fotis Georgatos <fotis.georgatos@uni.lu>
Signed-off-by: Fotis Georgatos <fotis.georgatos@uni.lu>
Signed-off-by: Fotis Georgatos <fotis.georgatos@uni.lu>
Signed-off-by: Fotis Georgatos <fotis.georgatos@uni.lu>
Signed-off-by: Fotis Georgatos <fotis.georgatos@uni.lu>
Signed-off-by: Fotis Georgatos <fotis.georgatos@uni.lu>
configopts += " --enable-float"

sanity_check_paths = {
'files': ['lib/libs%s.so' % x for x in ['fftw', 'fftw_threads', 'rfftw', 'rfftw_threads']],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation?

boegel and others added 3 commits May 22, 2013 20:48
…build-easyconfigs into contrib_FFTW_v2.1.5_only
transform FFTW 2.1.5 easyconfigs into fat builds (both float and double libs/header files)
@fgeorgatos
Copy link
Contributor Author

I didn't really get what the configopts[] list is trully doing but I trust Kenneth because I have to :-P

In the meantime, I can distract you all with a URL I use as reference about alternative build modes:
https://www.clumeq.ca/wiki/index.php/ModulesDisponiblesSurColosse
I notice that the vec-recurse is used by default across multiple cases, including linux distributions; I'd add it in, no?
fyi. the current configopts diff from the last one is: --enable-vec-recurse --enable-fortran --enable-mpi --without-openmp

@boegel
Copy link
Member

boegel commented May 22, 2013

From configure --help:

  --enable-vec-recurse    enable experimental performance hack

So, it doesn't seem like a good idea to use it in the default FFTW 2.1.5 easyconfig we ship.

@boegel
Copy link
Member

boegel commented May 22, 2013

After discussing this with @fgeorgatos: ready to merge in!

boegel added a commit that referenced this pull request May 22, 2013
contrib FFTW/2.1.5 and improve sources directive where needed
@boegel boegel merged commit 41637bb into easybuilders:develop May 22, 2013
@fgeorgatos fgeorgatos deleted the contrib_FFTW_v2.1.5_only branch May 26, 2013 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants