Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{lang}[*] flex: Make Bison a build dependency #3656

Merged
merged 1 commit into from
Oct 11, 2016

Conversation

geimer
Copy link
Contributor

@geimer geimer commented Oct 10, 2016

As discussed on the mailing list a couple of weeks ago, Bison is not really necessary for using flex and can thus be specified as a build dependency. This PR implements this change for flex 2.6.0, and also adds a checksum for the source tarball. If this change is considered OK, I can prepare corresponding PRs for older versions of flex available in the repo.

Note: This change may potentially break packages that only (build-)depend on flex rather than depending on both flex and Bison. However, how many packages are affected is hard to predict.

edit: ref to thread on ML: https://lists.ugent.be/wws/arc/easybuild/2016-08/msg00017.html

@geimer
Copy link
Contributor Author

geimer commented Oct 10, 2016

Test report by @geimer
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in this PR)
swat - Linux debian 7.11, Intel(R) Xeon(R) CPU X5550 @ 2.67GHz, Python 2.7.3
See https://gist.github.com/d868c105039f2497f02d592cd37aeee3 for a full test report.

@boegel boegel added this to the 3.0 milestone Oct 11, 2016
@boegel
Copy link
Member

boegel commented Oct 11, 2016

Test report by @boegel
SUCCESS
Build succeeded for 15 out of 15 (15 easyconfigs in this PR)
node2576.golett.os - Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/e6d51f029bb5341438cf1fae3ea4dd9b for a full test report.

@boegel
Copy link
Member

boegel commented Oct 11, 2016

We have 162 easyconfigs in our easyconfigs repo that list flex as a (build) dep, and each one of them also lists Bison as a (build) dep, so this should be OK.

Of course, we don't control all easyconfigs out there, but the upcoming EasyBuild v3.0 gives us an excuse to make this in theory backwards-incompatible change.

So: lgtm, thanks @geimer!

@boegel
Copy link
Member

boegel commented Oct 11, 2016

Test report by @boegel
SUCCESS
Build succeeded for 15 out of 15 (15 easyconfigs in this PR)
node2033.delcatty.os - Linux SL 6.8, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/5ea49d78dc91ca248069c18b8aabe145 for a full test report.

@boegel
Copy link
Member

boegel commented Oct 11, 2016

Going in, thanks @geimer!

@boegel boegel merged commit aea3257 into easybuilders:develop Oct 11, 2016
@geimer geimer deleted the flex_deps branch October 13, 2016 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants