Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add easyconfig files for slalib-c #750

Merged
merged 1 commit into from Mar 14, 2014
Merged

Conversation

boegel
Copy link
Member

@boegel boegel commented Mar 14, 2014

No description provided.

@boegel boegel added this to the v1.12 milestone Mar 14, 2014
@fgeorgatos
Copy link
Contributor

reviewed and looks OK, except for the ambitious version number...

@boegel
Copy link
Member Author

boegel commented Mar 14, 2014

@fgeorgatos: that's the only version available (once you get your hands on it) :-)

Thanks for the review!

boegel added a commit that referenced this pull request Mar 14, 2014
add easyconfig files for slalib-c
@boegel boegel merged commit 3b9a822 into easybuilders:develop Mar 14, 2014
@boegel boegel deleted the slalib branch March 14, 2014 10:53
@fgeorgatos
Copy link
Contributor

Test report by @fgeorgatos
FAILED
Build succeeded for 0 out of 2
Linux debian 6.0.9, Intel(R) Xeon(R) CPU E5-2660 0 @ 2.20GHz, Python 2.6.6
See https://gist.github.com/b47d97a733418d6e6748 for a full test report.

easyblock = 'ConfigureMake'

name = 'slalib-c'
version = '0.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one proposition for this situation:

Take an established build date as a previsionary version (eg. "20140313"),
add a versionsuffix that corresponds to a crc32 or other hash value
and then use the later as a constraint in the sources step. That would be a quite robust build process, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants