Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for only (re)generating module file #1018

Merged
merged 8 commits into from Apr 24, 2015

Conversation

boegel
Copy link
Member

@boegel boegel commented Aug 22, 2014

This adds support for only (re)generating a module file. The sanity check is still run, to make sure that the software installation was already taken care of, unless --force is used, then you can also generate for non-existing installations (which is great when experimenting with a particular module naming scheme).

One thing which is not possible (yet) with this is to generate module files for existing installations using a different module naming scheme, since the installation prefix always matches the module name being used.

This could probably be fixed as well, but needs extra logic and probably and extra command line parameter, to specify using which naming scheme an existing installation was installed (so the software installation prefix can be found).

skip = True
# allow skipping sanity check too when only generating module via --force
elif build_option('only_module') and step == 'sanitycheck' and build_option('force'):
self.log.info("Skipping %s step, due to combo of --only-module and --force" in ['sanitycheck'])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's with the info message? it just does self.log.info(False)

Conflicts:
	easybuild/main.py
	easybuild/tools/config.py
	easybuild/tools/options.py
@boegel boegel mentioned this pull request Mar 11, 2015
8 tasks
@@ -1580,7 +1591,11 @@ def sanity_check_step(self, custom_paths=None, custom_commands=None, extension=F
self.log.warning("Sanity check: %s" % self.sanity_check_fail_msgs[-1])

# chdir to installdir (better environment for running tests)
os.chdir(self.installdir)
if os.path.exists(self.installdir):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be isdi, and there should be an else block with some error

@hpcugentbot
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1660/
Test FAILed.

@hpcugentbot
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1661/
Test PASSed.

@boegel
Copy link
Member Author

boegel commented Apr 24, 2015

Remarks fixed, this looks a lot cleaner now, thanks for the suggestions @stdweird!

I'll tackle documentation updates all in one go (while regtest is running).

boegel added a commit that referenced this pull request Apr 24, 2015
add support for only (re)generating module file
@boegel boegel merged commit 5ee5bc9 into easybuilders:develop Apr 24, 2015
@boegel boegel deleted the only_module branch April 24, 2015 15:49
@fgeorgatos
Copy link
Collaborator

Copying an oneliner from today's IRC bubbles, showing where this is heading to:
[11:52:59] <boegel> eb —only-module —installpath-modules=/tmp/$USER/modules —software-installdir-naming-scheme=EasyBuildMNS —module-naming-scheme=HierarchicalMNS —modules-syntax=Lua

@boegel
Copy link
Member Author

boegel commented Apr 24, 2015

@fgeorgatos: that's only partially relevant anymore, since --software-installdir-naming-scheme is no longer there; and --only-module was renamed to --module-only to avoid misinterpretation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants