-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue with templates defined by deps being required while still parsing deps #1812
Conversation
@boegel having manually applied the new version of
and it worked, without generating the errors I reported in easybuilders/easybuild-easyconfigs#3210 |
self.log.debug("Obtained minimal toolchain: %s", tc) | ||
else: | ||
self.log.debug("Inheriting parent toolchain %s for dependency %s", tc, dependency) | ||
self.log.debug("Inheriting parent toolchain %s for dependency %s (for now)", tc, dependency) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@boegel - can you clarify what you mean by "(for now)" here? This is an interim fix, or just "for now" as part of the dependency resolution process?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With minimal-toolchains
you might be replacing this toolchain with one further down the hierarchy when the dependencies are finalised. Probably could do with replacing (for now)
by (until dependencies are finalised)
@boegel Tested with |
lgtm |
👍 |
This should fix the problems being reported in #1402 and easybuilders/easybuild-easyconfigs#3210.
cc @verdurin, @ocaisa