Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify error message when no software-specific easyblock was found #2178

Merged
merged 2 commits into from
Mar 22, 2017

Conversation

boegel
Copy link
Member

@boegel boegel commented Mar 22, 2017

This changes a very cryptic error message like:

NO LONGER SUPPORTED since v2.0: Fallback to default easyblock ConfigureMake
(from easybuild.easyblocks.generic.configuremake); use "easyblock = \'ConfigureMake\'" in
easyconfig file?;
see http://easybuild.readthedocs.org/en/latest/Deprecated-functionality.html for more information

to:

No software-specific easyblock 'EB_MXNet' found for MXNet

I made a breaking change to the signature of get_easyblock_class for this, basically replacing the default_fallback optional argument with error_on_missing_easyblock.

Should I include a deprecation warning for that, which detects the use of default_fallback and assigns error_on_missing_easyblock instead? Just in case this breaks a script that talks with the framework API?

@boegel boegel added this to the 3.2.0 milestone Mar 22, 2017
@wpoely86
Copy link
Member

We should probably not break api during minor releases?

@boegel
Copy link
Member Author

boegel commented Mar 22, 2017

@wpoely86 updated, please rereview?

@boegel
Copy link
Member Author

boegel commented Mar 22, 2017

Thanks for the review @wpoely86!

@boegel boegel merged commit ae4c504 into easybuilders:develop Mar 22, 2017
@boegel boegel deleted the no_software_specific_easyblock branch March 22, 2017 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants