Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module append text #954

Merged
merged 1 commit into from
Jul 8, 2014
Merged

Conversation

pescobar
Copy link
Member

with this you can define in your easyconfig whatever text you want to add to the generated modulefile. You have to be aware that the text fits the modulefile syntax.

ex. in module file you add:

modextraappend = """
if [ module-info mode load ] {
    puts stderr     "To execute GATK run: java -jar \$EBROOTGATK/GenomeAnalysisTK.jar"
}
"""

and you will get exactly that text in the modulefile

@boegel
Copy link
Member

boegel commented Jun 20, 2014

@pescobar: how is this different from --modules-footer? Is this basically the equivalent of that to define in easyconfigs? Why not call it modules_footer too?

@pescobar
Copy link
Member Author

as @boegel suggested I renamed the option to modextratclfooter, so now the easyconfig would be like this

modextratclfooter = """
if [ module-info mode load ] {
    puts stderr     "To execute GATK run: java -jar \$EBROOTGATK/GenomeAnalysisTK.jar"
}
"""

@boegel
Copy link
Member

boegel commented Jun 21, 2014

@pescobar: this parameter certainly has its uses (e.g. via --try-amend), but when people start including Tcl text in their easyconfigs they will run into trouble later when switching to Lmod & Lua module files (they will at some point ;-)).

So, how about adding a generic modextraloadmgs parameter too, which takes a list of strings (messages to print on loading of the module)?
That way, this can be supported in both Tcl & Lua module files by EasyBuild, without having to rewrite easyconfig files when you make the switch...

@pescobar
Copy link
Member Author

@boegel do you prefer a different PR for the modextraloadmsg or I add it to this PR?

@boegel
Copy link
Member

boegel commented Jun 21, 2014

@pescobar: feel free to add it in here, it won't make the PR that much bigger (and make it plural, msgs)

@boegel
Copy link
Member

boegel commented Jul 3, 2014

@pescobar: ping on the modextraloadmsg? If you're not planning to work on that soon, it can be done via a separate PR.

sync with develop to resolve conflict
@boegel
Copy link
Member

boegel commented Jul 8, 2014

merged in (via #974), thanks @pescobar!

boegel added a commit that referenced this pull request Jul 8, 2014
@boegel boegel merged commit 248a978 into easybuilders:develop Jul 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants