Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from nose to pytest #66

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

hemna
Copy link
Contributor

@hemna hemna commented May 14, 2019

This patch migrates all of the unit tests to use the pytest mechanism
from nose. nose and nosetests are long dead and no longer supported.

This updates tox.ini and setup.py to use pytest now. Also all of the tests
have been updated to work with pytest too.

hemna added 2 commits May 14, 2019 17:59
This patch migrates all of the unit tests to use the pytest mechanism
from nose.  nose and nosetests are long dead and no longer supported.
Copy link
Contributor

@sneharai4 sneharai4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hemna Is this PR still needed?

@hemna
Copy link
Contributor Author

hemna commented Sep 8, 2019

Yes, did you read the reason for the pull request? nose and nosetests are dead projects that aren't supported. This patch is needed to keep the client using active projects for testing as well as building RPMs for distributions.

@wdurairaj
Copy link
Collaborator

wdurairaj commented Sep 8, 2019

@hemna your earlier PR which you had proposed for wheels distribution has these changes and that's the reason for @sneharai4 question on this... Yes we read your description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants