fix: forward events from dynamic components correctly

hperrin · Dec 30, 2020 · 5367449 · 5367449
1 parent b011df9
commit 5367449
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/packages/chips/Chip.svelte b/packages/chips/Chip.svelte
@@ -2,6 +2,7 @@
   this={component}
   bind:element={element}
   use={[forwardEvents, ...use]}
+  forwardEvents={forwardedEvents}
   class="
     mdc-chip
     {className}
@@ -30,7 +31,8 @@
   import {exclude} from '@smui/common/exclude.js';
   import Div from "@smui/common/Div.svelte";
 
-  const forwardEvents = forwardEventsBuilder(get_current_component(), ['MDCChip:interaction', 'MDCChip:selection', 'MDCChip:removal', 'MDCChip:trailingIconInteraction', 'MDCChip:navigation']);
+  const forwardedEvents = ['MDCChip:interaction', 'MDCChip:selection', 'MDCChip:removal', 'MDCChip:trailingIconInteraction', 'MDCChip:navigation'];
+  const forwardEvents = forwardEventsBuilder(get_current_component(), forwardedEvents);
 
   export let use = [];
   let className = '';

diff --git a/packages/icon-button/IconButton.svelte b/packages/icon-button/IconButton.svelte
@@ -2,7 +2,7 @@
   this={component}
   bind:element={element}
   use={[[Ripple, {ripple: ripple && !toggle, unbounded: true, color, disabled: !!$$props.disabled, classForward: classes => rippleClasses = classes}], forwardEvents, ...use]}
-  forwardEvents={['MDCIconButtonToggle:change']}
+  forwardEvents={forwardedEvents}
   class="
     mdc-icon-button
     {className}
@@ -30,7 +30,8 @@
   import Button from '@smui/common/Button.svelte';
   import Ripple from '@smui/ripple/bare.js';
 
-  const forwardEvents = forwardEventsBuilder(get_current_component(), ['MDCIconButtonToggle:change']);
+  const forwardedEvents = ['MDCIconButtonToggle:change'];
+  const forwardEvents = forwardEventsBuilder(get_current_component(), forwardedEvents);
 
   export let use = [];
   let className = '';

diff --git a/packages/tab/Tab.svelte b/packages/tab/Tab.svelte
@@ -2,6 +2,7 @@
   this={component}
   bind:this={element}
   use={[forwardEvents, ...use]}
+  forwardEvents={forwardedEvents}
   class="
     mdc-tab
     {className}
@@ -51,7 +52,8 @@
   import Button from '@smui/common/Button.svelte';
   import TabIndicator from '@smui/tab-indicator/TabIndicator.svelte';
 
-  const forwardEvents = forwardEventsBuilder(get_current_component(), ['MDCTab:interacted']);
+  const forwardedEvents = ['MDCTab:interacted'];
+  const forwardEvents = forwardEventsBuilder(get_current_component(), forwardedEvents);
   let activeEntry = getContext('SMUI:tab:active');
 
   export let use = [];