fix: floating label noLabel default to false

hperrin · Apr 12, 2021 · cf06c28 · cf06c28
1 parent 383268d
commit cf06c28
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/packages/notched-outline/NotchedOutline.svelte b/packages/notched-outline/NotchedOutline.svelte
@@ -43,7 +43,7 @@
   let className = '';
   export { className as class };
   export let notched = false;
-  export let noLabel = true;
+  export let noLabel = false;
 
   let element;
   let instance;

diff --git a/site/src/routes/demo/textfield/index.svelte b/site/src/routes/demo/textfield/index.svelte
@@ -678,10 +678,14 @@
         <Textfield
           bind:input={inputManualInputC}
           bind:notchedOutline={inputManualNotchedOutlineC}
+          bind:floatingLabel={inputManualFloatingLabelC}
           variant="outlined"
         >
           <NotchedOutline bind:this={inputManualNotchedOutlineC} slot="label">
-            <FloatingLabel for="input-manual-c">Outlined</FloatingLabel>
+            <FloatingLabel
+              bind:this={inputManualFloatingLabelC}
+              for="input-manual-c">Outlined</FloatingLabel
+            >
           </NotchedOutline>
           <Icon class="material-icons" slot="leadingIcon">event</Icon>
           <Input
@@ -702,10 +706,14 @@
         <Textfield
           bind:input={inputManualInputD}
           bind:notchedOutline={inputManualNotchedOutlineD}
+          bind:floatingLabel={inputManualFloatingLabelD}
           textarea
         >
           <NotchedOutline bind:this={inputManualNotchedOutlineD} slot="label">
-            <FloatingLabel for="input-manual-d">Textarea</FloatingLabel>
+            <FloatingLabel
+              bind:this={inputManualFloatingLabelD}
+              for="input-manual-d">Textarea</FloatingLabel
+            >
           </NotchedOutline>
           <Textarea
             bind:this={inputManualInputD}
@@ -800,10 +808,12 @@
   let valueManualC = '';
   let inputManualInputC;
   let inputManualNotchedOutlineC;
+  let inputManualFloatingLabelC;
 
   let valueManualD = '';
   let inputManualInputD;
   let inputManualNotchedOutlineD;
+  let inputManualFloatingLabelD;
 
   function clickableHandler() {
     alert(`Sending to ${valueClickable}!`);