fix: data table checkboxes and sorting

hperrin · Sep 14, 2021 · e88a19c · e88a19c
1 parent 048a11d
commit e88a19c
Show file tree

Hide file tree

Showing 8 changed files with 13 additions and 11 deletions.
diff --git a/packages/chips/Text.svelte b/packages/chips/Text.svelte
@@ -74,7 +74,7 @@
     dispatch(getElement(), 'SMUIChipsChipPrimaryAction:mount', accessor);
 
     return () => {
-      dispatch(getElement(), 'SMUIChipsChipPrimaryAction:unmount');
+      dispatch(getElement(), 'SMUIChipsChipPrimaryAction:unmount', accessor);
     };
   });
 

diff --git a/packages/chips/TrailingAction.svelte b/packages/chips/TrailingAction.svelte
@@ -106,7 +106,7 @@
     instance.init();
 
     return () => {
-      dispatch(getElement(), 'SMUIChipsChipTrailingAction:unmount');
+      dispatch(getElement(), 'SMUIChipsChipTrailingAction:unmount', accessor);
 
       instance.destroy();
     };

diff --git a/packages/data-table/Body.svelte b/packages/data-table/Body.svelte
@@ -51,10 +51,10 @@
       },
     };
 
-    dispatch(getElement(), 'SMUI:data-table:body:mount', accessor);
+    dispatch(getElement(), 'SMUIDataTableBody:mount', accessor);
 
     return () => {
-      dispatch(getElement(), 'SMUI:data-table:body:unmount');
+      dispatch(getElement(), 'SMUIDataTableBody:unmount', accessor);
     };
   });
 

diff --git a/packages/data-table/Cell.svelte b/packages/data-table/Cell.svelte
@@ -144,7 +144,7 @@
     dispatch(getElement(), 'SMUIDataTableCell:mount', accessor);
 
     return () => {
-      dispatch(getElement(), 'SMUIDataTableCell:unmount');
+      dispatch(getElement(), 'SMUIDataTableCell:unmount', accessor);
     };
   });
 

diff --git a/packages/data-table/DataTable.svelte b/packages/data-table/DataTable.svelte
@@ -318,10 +318,12 @@
       '.mdc-data-table__header-cell--with-sort'
     ) as HTMLTableCellElement;
 
-    if (!headerCell) {
-      return;
+    if (headerCell) {
+      handleSortAction(headerCell);
     }
+  }
 
+  function handleSortAction(headerCell: HTMLTableCellElement) {
     const orderedCells = header?.orderedCells ?? [];
 
     const columnIndex = orderedCells

diff --git a/packages/data-table/Head.svelte b/packages/data-table/Head.svelte
@@ -51,10 +51,10 @@
       },
     };
 
-    dispatch(getElement(), 'SMUI:data-table:header:mount', accessor);
+    dispatch(getElement(), 'SMUIDataTableHeader:mount', accessor);
 
     return () => {
-      dispatch(getElement(), 'SMUI:data-table:header:unmount');
+      dispatch(getElement(), 'SMUIDataTableHeader:unmount', accessor);
     };
   });
 

diff --git a/packages/data-table/Row.svelte b/packages/data-table/Row.svelte
@@ -93,7 +93,7 @@
     dispatch(getElement(), 'SMUIDataTableRow:mount', accessor);
 
     return () => {
-      dispatch(getElement(), 'SMUIDataTableRow:unmount');
+      dispatch(getElement(), 'SMUIDataTableRow:unmount', accessor);
     };
   });
 

diff --git a/packages/site/src/routes/demo/dialog/_List.svelte b/packages/site/src/routes/demo/dialog/_List.svelte
@@ -24,7 +24,7 @@
 <Button on:click={() => (open = true)}><Label>Open Dialog</Label></Button>
 
 <pre
-  class="status">Clicked: {clicked}{clicked === 69 ? ', nice' : clicked === 42 ? ', life, the universe, and everything' : ''}</pre>
+  class="status">Clicked: {clicked}{clicked === 69 ? ', nice' : clicked === 42 ? ', the answer to life, the universe, and everything' : ''}</pre>
 
 <script lang="ts">
   import Dialog, { Title, Content } from '@smui/dialog';