Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte Select like Component #21

Closed
bwbroersma opened this issue Aug 23, 2019 · 10 comments
Closed

Svelte Select like Component #21

bwbroersma opened this issue Aug 23, 2019 · 10 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@bwbroersma
Copy link

Would be great to have a (Multi) Select that has filtering, virtual-list, etc. like (the great) svelte-select.

@hperrin hperrin added enhancement New feature or request help wanted Extra attention is needed labels Aug 23, 2019
@hperrin
Copy link
Owner

hperrin commented Aug 29, 2019

I'm not sure actually, whether this component would fit into Material Design. What features do you want from this component that aren't present in the select component?

@caschbre
Copy link

I use svelte-select mixed in with svelte-material-ui... mainly for the auto-complete and ability to pull the options from an API.

@oculardexterity
Copy link

I use svelte-select mixed in with svelte-material-ui... mainly for the auto-complete and ability to pull the options from an API.

Can you give me an example of this?

@bwbroersma
Copy link
Author

bwbroersma commented Sep 9, 2019

@hperrin Mainly I would want the 'combo' feature of typing in the Select to filter the options (kind of auto-complete?), and virtual-list support to handle a lot of options.

@caschbre
Copy link

I use svelte-select mixed in with svelte-material-ui... mainly for the auto-complete and ability to pull the options from an API.

Can you give me an example of this?

I just mean that I use svelte-select in my project alongside svelte-material-ui. There isn't a specific integration between the two. So if I want auto-complete or data pulled from an API then I use svelte-select, otherwise I use the Select component from smui.

@caschbre
Copy link

@hperrin I see you have this tagged help wanted.... are you thinking the existing Select component would be modified to accommodate the additional functionality or would a completely new component be ideal? I may have some time to take a crack at it.

@hperrin
Copy link
Owner

hperrin commented Sep 12, 2019

@caschbre I think this should be done as a separate component that uses @smui/select. That way we would keep the bundle size the same if you didn't use the extra features.

@ghost
Copy link

ghost commented Sep 14, 2019

I think virtual list would not be essential for this.

@mwamp
Copy link
Contributor

mwamp commented Oct 5, 2019

I am not sure what you guys want exactly but it looks to me that we might actually want to tweak svelte-select so it accepts smui/Select&Option as slots no?
This would make sense as the features you mention are about logic when smui is more about view?
This way we could define a Select interface which could be shared between svelte ui libraries?

@hperrin
Copy link
Owner

hperrin commented Nov 10, 2021

Since there is a new release (5.0), and this issue was filed prior to that release and hasn't had any updates in at least six months, I'm going to close it as part of a mass issue clean up. If this issue is still relevant, please re-open it and mention me in a comment, and I will triage the issue into a relevant milestone. Thank you for your patience, and I apologize for any inconvenience.

@hperrin hperrin closed this as completed Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants