Bump version to 0.19 for firmware key fix #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The submitter of #44 indicated that they were up and running with a workaround so I didn't see an immediate need to push out a new release to pypi. There's a certain amount of friction in my environment in pushing out a release so I was being lazy. If people need a new release then I can do it. |
|
Yeah, there is a downstream issue (home-assistant/core#74759) where consumers of this library have been hosed since July. I use this library myself, so I am also affected. We would definitely greatly appreciate the bump. |
|
Sorry it took so long. Had to build a new dev machine and took a while to get everything working; plus work pressures, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the firmware key check was fixed in #44, the package version remained the same, so any downstream project relying upon package management versioning, won't receive the patch. The one I'm thinking of in particular is Home Assistant.
This PR simply bumps the version number from 0.18 to 0.19, so a rebuild and push to PyPI can also be facilitated. Hopefully that's okay, and you didn't have any further changes in mind before incrementing versions. Thanks for your help.