Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new() swallows sleepwait parameter #39

Closed
srenfo opened this issue Sep 28, 2015 · 1 comment
Closed

new() swallows sleepwait parameter #39

srenfo opened this issue Sep 28, 2015 · 1 comment

Comments

@srenfo
Copy link

srenfo commented Sep 28, 2015

hpfeeds.py: new swallows sleepwait

Submitting this as an issue rather than as a patch because it almost looks intentional what with the certfile=certfile business in the HPC_SSL line.

If it's not intentional then I suggest the defaults of __init__ be removed in addition to the fix.
@Jc2k
Copy link
Collaborator

Jc2k commented Jan 28, 2020

Hi - just closing down some old tickets from before I joined the team. Sorry that this ticket wasn't picked up at the time.

The current code passes any left over kwargs from new() into both classes which i think fixes this.

@Jc2k Jc2k closed this as completed Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Jc2k @srenfo