Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Renamer post processor does'nt call the next ones #76

Closed
grzi opened this issue Apr 9, 2019 · 1 comment
Closed

The Renamer post processor does'nt call the next ones #76

grzi opened this issue Apr 9, 2019 · 1 comment
Assignees
Labels

Comments

@grzi
Copy link

grzi commented Apr 9, 2019

Hi,

I've seen that when we use the RenameByMapping that extends the Renamer PostProcessor, it won't call the following postProcessors (if they exist).

I think this is a bug.

As the fix seems easy, I can provide a PR.

How to reproduce :

  • Create a sample post processor
  • Use this line when creating the connector : "mongodb.post.processor.chain":"at.grahsl.kafka.connect.mongodb.processor.field.renaming.RenameByMapping,your.sample.TestPostProcessor"

Expected Behaviour

The TestPostProcessor process method should be called after the process of RenameByMapping

Actual Behaviour

The TestPostProcessor process isn't called

@hpgrahsl hpgrahsl self-assigned this Apr 11, 2019
@hpgrahsl hpgrahsl added the bug label Apr 11, 2019
@hpgrahsl
Copy link
Owner

Many THX @zthulj for spotting and reporting this bug. It's correct that it has to call potential next post processors in order not to break the chain. I am going to fix this with the next patch release 1.3.1 which is planned to get done soonish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants