Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/564 future proof deserialization with exceptions v2 #583

Conversation

johannesvedder
Copy link
Contributor

No description provided.

@johannesvedder johannesvedder changed the base branch from dev to issue/564-future-proof-deserialization-with-exceptions February 6, 2024 18:55
@johannesvedder johannesvedder changed the base branch from issue/564-future-proof-deserialization-with-exceptions to dev February 6, 2024 18:56
@johannesvedder johannesvedder changed the base branch from dev to issue/564-future-proof-deserialization-with-exceptions February 6, 2024 18:57
Copy link

github-actions bot commented Feb 6, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ REPOSITORY git_diff yes no 0.06s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 6, 2024
Copy link

github-actions bot commented Feb 6, 2024

Visit the preview URL for this PR (updated for commit 4639fd7):

(expires Wed, 13 Mar 2024 09:44:43 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2149dad49ed83535217e50d5c18c0c8c90da629b

@johannesvedder johannesvedder reopened this Feb 7, 2024
@johannesvedder johannesvedder force-pushed the issue/564-future-proof-deserialization-with-exceptions-v2 branch from 7d7f964 to ef260d1 Compare February 7, 2024 12:35
Copy link
Contributor

@hig-dev hig-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using an exception to capture the extracted and not extracted studies is a smart idea and has the benefit that we can leave the other methods unchanged and only change publishedPublicStudies(). Personally, I would prefer the solution with less exceptions but that is personal taste.

app/lib/l10n/app_de.arb Outdated Show resolved Hide resolved
core/lib/src/util/supabase_object.dart Show resolved Hide resolved
core/lib/src/util/supabase_object.dart Outdated Show resolved Hide resolved
@johannesvedder johannesvedder force-pushed the issue/564-future-proof-deserialization-with-exceptions-v2 branch from 58022cb to b82e65a Compare February 29, 2024 19:35
@hig-dev
Copy link
Contributor

hig-dev commented Mar 4, 2024

This can be merged when #591 is merged.

…alization-with-exceptions-v2-hig

refactor: improve return type of publishedPublicStudies()
@hig-dev hig-dev merged commit b2ebb56 into issue/564-future-proof-deserialization-with-exceptions Mar 6, 2024
13 checks passed
@hig-dev hig-dev deleted the issue/564-future-proof-deserialization-with-exceptions-v2 branch March 6, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app core documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants