-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/564 future proof deserialization with exceptions v2 #583
Issue/564 future proof deserialization with exceptions v2 #583
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Visit the preview URL for this PR (updated for commit 4639fd7):
(expires Wed, 13 Mar 2024 09:44:43 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2149dad49ed83535217e50d5c18c0c8c90da629b |
7d7f964
to
ef260d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using an exception to capture the extracted and not extracted studies is a smart idea and has the benefit that we can leave the other methods unchanged and only change publishedPublicStudies()
. Personally, I would prefer the solution with less exceptions but that is personal taste.
58022cb
to
b82e65a
Compare
b82e65a
to
5ef1bc4
Compare
This can be merged when #591 is merged. |
…alization-with-exceptions-v2-hig refactor: improve return type of publishedPublicStudies()
b2ebb56
into
issue/564-future-proof-deserialization-with-exceptions
No description provided.