Fixes an issue in ContextS2 resulting from using class identity inste…

…ad of name when determining whether two partial methods are the same. As a result the partial method is not correctly removed in case of a recompile within a new class.
hpi-swa-lab · Aug 23, 2023 · b46aace · b46aace
1 parent 802deac
commit b46aace
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 0 deletions.
diff --git a/packages/Babylonian-Compiler.package/CSPartialMethod.extension/instance/^equals.st b/packages/Babylonian-Compiler.package/CSPartialMethod.extension/instance/^equals.st
@@ -0,0 +1,8 @@
+*Babylonian-Compiler
+= anotherPartialMethod
+	"see #hash"
+
+	^ anotherPartialMethod class == self class
+	and: [self basicLayers = anotherPartialMethod basicLayers
+	and: [self selector = anotherPartialMethod selector
+	and: [self methodClass name = anotherPartialMethod methodClass name]]]
diff --git a/packages/Babylonian-Compiler.package/CSPartialMethod.extension/instance/hash.st b/packages/Babylonian-Compiler.package/CSPartialMethod.extension/instance/hash.st
@@ -0,0 +1,5 @@
+*Babylonian-Compiler
+hash
+	"see #="
+
+	^ (self basicLayers hash bitXor: self selector hash) bitXor: self class name hash
diff --git a/packages/Babylonian-Compiler.package/CSPartialMethod.extension/methodProperties.json b/packages/Babylonian-Compiler.package/CSPartialMethod.extension/methodProperties.json
@@ -0,0 +1,6 @@
+{
+	"class" : {
+		 },
+	"instance" : {
+		"=" : "sp 8/23/2023 14:35",
+		"hash" : "sp 8/23/2023 14:36" } }
diff --git a/packages/Babylonian-Compiler.package/CSPartialMethod.extension/properties.json b/packages/Babylonian-Compiler.package/CSPartialMethod.extension/properties.json
@@ -0,0 +1,2 @@
+{
+	"name" : "CSPartialMethod" }