-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistent Theme Styling for Annotations + auto update on change #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5454038473
💛 - Coveralls |
…babylonian-programming-smalltalk into error/theme-styling
…babylonian-programming-smalltalk into error/theme-styling
…babylonian-programming-smalltalk into error/theme-styling
ekrebs5
requested changes
Jul 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general, just have a few inputs:
- it tries to readd the printbugger package; this is the probelog now
- see comment that one color could be extracted to its own function
- as seen in the screenshots, dark themes such as Monokai (dark) retain a light color for some Babylonian Morphs if the browser is open during the change; can this be fixed or will a browser reopen be neccessary here?
packages/Babylonian-UI.package/BPMethodExampleMorph.class/instance/addArgumentScriptMorphs.st
Outdated
Show resolved
Hide resolved
@ekrebs5 did you mean the printbugger in the .ston? or elsewhere? |
ekrebs5
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, many colors are hardcoded throughout the code. This leads to hardly readable, or unreadable text depending on the theme, e.g. the grey of the buttons in a dark theme
![Screenshot 2023-05-16 193223](https://private-user-images.githubusercontent.com/33000454/250401187-f48dd2df-5665-4a15-9d9e-3eb93894e969.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk5NTY4MDAsIm5iZiI6MTcxOTk1NjUwMCwicGF0aCI6Ii8zMzAwMDQ1NC8yNTA0MDExODctZjQ4ZGQyZGYtNTY2NS00YTE1LTlkOWUtM2ViOTM4OTRlOTY5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzAyVDIxNDE0MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ1OWVlN2I1OWRlZTdhMTNkNjlmODU1YzU4NzQzMDI0YWY4NWNlZTZkMTRiMDM0ZDRhMjJkMjY5M2ZjNmM4YTEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.X0t-oZs5dBTu7_OLHI_rqBd4OS0tcH-zuDMzjsDVxCs)
![Screenshot 2023-05-31 140808](https://private-user-images.githubusercontent.com/33000454/250401504-241ef38e-21cb-4af5-b13a-d0028e779540.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk5NTY4MDAsIm5iZiI6MTcxOTk1NjUwMCwicGF0aCI6Ii8zMzAwMDQ1NC8yNTA0MDE1MDQtMjQxZWYzOGUtMjFjYi00YWY1LWIxM2EtZDAwMjhlNzc5NTQwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzAyVDIxNDE0MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWM3MTVhZGZkZDFkNDFhMjhjZDdmOWUwNmVhMWZhNTE0NGUzNGNlZDdiNDM3ZjFmNzMyMWIzZDZkMDhjOTM4ODkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.j8xeTiU6AtNbaPvdqM9H5nV8n0JD6tO-ytw-4_UoZ5I)
or backgrounds were inconsistent
With this MR, colors adjust themselves to the theme and change automatically when a new change is applied.
Many
applyUserInterfaceTheme
and UI constants were added. As the values morph for Probes was different with each class, fullfilling the same purpose, they were extracted into their own classes.BPBrowser
now invalidates itself when a theme changed. This is because in the scenarioa
with probesb
a
the probes in
a
would still have the old theme as they were not rendered before.Below are two example themes.