Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Displays active examples first in ProbeLog column selection #151

Merged
merged 5 commits into from
Jul 4, 2023
Merged

Displays active examples first in ProbeLog column selection #151

merged 5 commits into from
Jul 4, 2023

Conversation

JoeAtHPI
Copy link
Collaborator

@JoeAtHPI JoeAtHPI commented Jul 4, 2023

#145 without package rename hassle

@JoeAtHPI JoeAtHPI requested a review from ekrebs5 July 4, 2023 13:14
@coveralls
Copy link

coveralls commented Jul 4, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5456056998

  • 11 of 28 (39.29%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.009%) to 65.057%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/Babylonian-ProbeLog.package/BPProbeLog.class/class/newForExamples..st 0 1 0.0%
packages/Babylonian-ProbeLog.package/BPProbeLog.class/instance/offerExampleSelectionMenu.st 0 7 0.0%
packages/Babylonian-ProbeLog.package/BPProbeLogColumnMorph.class/instance/offerExampleSelectionMenu.st 0 9 0.0%
Files with Coverage Reduction New Missed Lines %
packages/Babylonian-ProbeLog.package/BPProbeLogColumnMorph.class/instance/offerExampleSelectionMenu.st 1 0%
Totals Coverage Status
Change from base Build 5454643656: -0.009%
Covered Lines: 1199
Relevant Lines: 1843
💛 - Coveralls

@JoeAtHPI JoeAtHPI self-assigned this Jul 4, 2023
@JoeAtHPI
Extracts examples display menu to a class method so it's unified betw…
44e6b71 
…een add & switch
@JoeAtHPI
Revert "Extracts examples display menu to a class method so it's unif…
74daf1c 
…ied between add & switch"

This reverts commit 44e6b71 "Extracts examples display menu to a class method so it's unified between add & switch"
@JoeAtHPI
Extracted adding line to according method so it's unified between add…
6bf0b7f 
… & switch button
@JoeAtHPI JoeAtHPI merged commit 93c0d03 into develop Jul 4, 2023
4 checks passed
@JoeAtHPI JoeAtHPI deleted the 141/active-examples-top branch August 9, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekrebs5 ekrebs5 ekrebs5 approved these changes

Assignees

@JoeAtHPI JoeAtHPI

Labels
probelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JoeAtHPI @coveralls @ekrebs5