deleted redundant assertions

hpi-swa-teaching · Aug 2, 2022 · 4eb59d5 · 4eb59d5
1 parent 867461d
commit 4eb59d5
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/...ts.package/AnimationsEditorKeyframeTest.class/instance/testChangeSelectedKeyframeValue.st b/...ts.package/AnimationsEditorKeyframeTest.class/instance/testChangeSelectedKeyframeValue.st
@@ -1,16 +1,18 @@
 testing
 testChangeSelectedKeyframeValue
-	| sizeBeforeChange oldValue oldTargetValues|
+	| oldValue oldTargetValues notChangedOldTargetValues newValue notChangedNewTargetValues|
 
 	self selectKeyframe100.
 
-	sizeBeforeChange := self propertyRotation targetValues size.
 	oldValue := self propertyRotation targetValues at: (self frameNumber100).
 	oldTargetValues := self propertyRotation targetValues deepCopy.
+	notChangedOldTargetValues := oldTargetValues removeKey: self frameNumber100; yourself.
+
 	self createKeyframeWith: self animationRotation200 on: self frameNumber100.
+
+	newValue := self propertyRotation targetValues at: self frameNumber100.
+	notChangedNewTargetValues := self propertyRotation targetValues removeKey: self frameNumber100; yourself.
 
-	self assert: sizeBeforeChange = self propertyRotation targetValues size.
-	self deny: oldValue equals: (self propertyRotation targetValues at: self frameNumber100).
-	self deny: oldTargetValues equals: self propertyRotation targetValues.
-	self assert: (oldTargetValues removeKey: self frameNumber100; yourself) equals: (self propertyRotation targetValues removeKey: self frameNumber100; yourself).
+	self deny: oldValue equals: newValue.
+	self assert: notChangedOldTargetValues equals: notChangedNewTargetValues.
 
diff --git a/...s/AnimationsEditor-Tests.package/AnimationsEditorKeyframeTest.class/methodProperties.json b/...s/AnimationsEditor-Tests.package/AnimationsEditorKeyframeTest.class/methodProperties.json
@@ -21,7 +21,7 @@
 		"selectKeyframe100" : "SG 8/2/2022 08:28",
 		"setUp" : "SG 8/1/2022 09:41",
 		"tearDown" : "SG 7/31/2022 23:22",
-		"testChangeSelectedKeyframeValue" : "SG 8/2/2022 09:22",
+		"testChangeSelectedKeyframeValue" : "SG 8/2/2022 13:21",
 		"testLeftClickShowsSelectedProperty" : "SG 8/2/2022 08:29",
 		"timeline" : "SG 7/31/2022 22:46",
 		"timeline:" : "SG 7/31/2022 22:46" } }