Skip to content

Commit

Permalink
warning message and class comments
Browse files Browse the repository at this point in the history
added warning message when not selecting a animatable property
extended class comments
  • Loading branch information
Max784 committed Aug 2, 2021
2 parents aa38f45 + 61e10f0 commit 657c66b
Show file tree
Hide file tree
Showing 21 changed files with 32 additions and 20 deletions.
Original file line number Diff line number Diff line change
@@ -1 +1 @@
This class is part of the timeline and displays keyframes.
This class is part of the timeline and displays keyframes as a rectangle inside of its according property track.
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
],
"classvars" : [
],
"commentStamp" : "MH 8/1/2021 19:57",
"commentStamp" : "CL 8/2/2021 08:54",
"instvars" : [
"track",
"frame",
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
defaults
addKeyframe
self animationsEditor updateInformationText: self messageSelectAnimatedProperty.
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
defaults
messageSelectAnimatedProperty
^ 'Please select a animatable property in order to add a keyframe.'
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"instance" : {
"<" : "DM 8/6/2020 10:57",
"<=" : "DM 8/6/2020 10:57",
"addKeyframe" : "CL 8/2/2021 08:56",
"animationString" : "CL 5/31/2021 14:40",
"animationsEditor" : "DM 8/5/2020 21:01",
"animationsEditor:" : "FH 8/1/2021 19:06",
Expand All @@ -14,6 +15,7 @@
"defaultSubproperties" : "FH 5/13/2021 11:24",
"hasSubproperties" : "DM 8/6/2020 11:02",
"isStartEnd" : "mjs 7/31/2021 17:19",
"messageSelectAnimatedProperty" : "CL 8/2/2021 08:57",
"parentProperty" : "LW 7/9/2021 14:01",
"parentProperty:" : "LW 7/9/2021 14:01",
"resetTargetMorphForAllProperties" : "CL 7/29/2021 18:03",
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
This is the superclass for all possible types of animations a morph can have.
This is the abstract superclass for all possible types of animations a morph can have.
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ addKeyframe
ifTrue: [self setStartValue].
self targetValues at: self targetFrame put: self currentValue deepCopy.
self targetValues sort.
self changed.
self changed: #addKeyframes.
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"class" : {
},
"instance" : {
"addKeyframe" : "FH 8/1/2021 19:13",
"addKeyframe" : "CL 8/2/2021 08:43",
"addStartFrame" : "FH 8/1/2021 19:13",
"animationProperty" : "CL 7/29/2021 11:55",
"buildInputFrameWith:" : "FH 8/1/2021 19:13",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
],
"classvars" : [
],
"commentStamp" : "MH 8/1/2021 19:58",
"commentStamp" : "CL 8/2/2021 08:53",
"instvars" : [
"targetDuration",
"targetFrame",
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
This class displays the time scale.
This class displays the time scale quantified by the start-end-property.
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
],
"classvars" : [
],
"commentStamp" : "MH 8/1/2021 20:04",
"commentStamp" : "CL 8/2/2021 08:50",
"instvars" : [
],
"name" : "AnimationsEditorTimebar",
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
This is the class that displays tracks and keyframes.
This is the class that displays tracks and keyframes. It observes the start-end-property in order to adjust its extent and the Timebar scale.
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
updating
update: anObject
update: aStartEndProperty
self updateExtent.
self startTime: anObject startTime.
self endTime: anObject endTime.
self startTime: aStartEndProperty startTime.
self endTime: aStartEndProperty endTime.
self createTracks.
self addTimebar.
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,5 @@
"timebar" : "MH 8/1/2021 18:57",
"timebar:" : "MH 8/1/2021 18:57",
"trackHeight" : "MH 8/1/2021 18:57",
"update:" : "MH 8/1/2021 18:58",
"update:" : "CL 8/2/2021 08:51",
"updateExtent" : "MH 8/1/2021 18:58" } }
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
],
"classvars" : [
],
"commentStamp" : "MH 8/1/2021 20:02",
"commentStamp" : "CL 8/2/2021 08:52",
"instvars" : [
"animationsEditor",
"timebar",
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
This class contains keyframes for its property.
This class contains keyframes for its property. It furthermore observes the property for changes.
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
updating
update: aProperty
self property: aProperty.
(self property isKindOf: AnimationsEditorProperty)
update: aSymbol
aSymbol = #addKeyframes
ifTrue: [self addKeyframes].
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@
"property" : "MH 8/1/2021 19:01",
"property:" : "MH 8/1/2021 19:01",
"textMargin" : "MH 8/1/2021 19:01",
"update:" : "MH 8/1/2021 19:01" } }
"update:" : "CL 8/2/2021 08:47" } }
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
],
"classvars" : [
],
"commentStamp" : "MH 8/1/2021 20:05",
"commentStamp" : "CL 8/2/2021 08:48",
"instvars" : [
"property" ],
"name" : "AnimationsEditorTrack",
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
testing
testShowMessageSelectAnimatedProperty
self property addKeyframe.
self assert: self animationsEditorInstance informationBarText = self property messageSelectAnimatedProperty.
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,5 @@
"testOnlyPlaysAnimationInsideStartEndTime" : "MH 8/1/2021 18:38",
"testPlayAnimationWithStartEnd" : "MH 8/1/2021 18:38",
"testShowMessageKeyframeOutOfBounds" : "MH 8/1/2021 18:38",
"testShowMessageSelectAnimatedProperty" : "CL 8/2/2021 09:05",
"testTargetValuesIsSorted" : "MH 8/1/2021 18:38" } }

0 comments on commit 657c66b

Please sign in to comment.