- fixed broken tests

- added list of methods for all tests planned
hpi-swa-teaching · May 23, 2021 · 7f6d817 · 7f6d817
1 parent bc0ccc2
commit 7f6d817
Show file tree

Hide file tree

Showing 22 changed files with 82 additions and 6 deletions.
diff --git a/...orTest.class/instance/testCreateAnimationForWithKeyWithLastKeyWithValueWithTargetValue.st b/...orTest.class/instance/testCreateAnimationForWithKeyWithLastKeyWithValueWithTargetValue.st
@@ -0,0 +1,4 @@
+as yet unclassified
+testCreateAnimationForWithKeyWithLastKeyWithValueWithTargetValue
+
+	"test that it returns a composite animation according to the input values"
diff --git a/...package/AnimationsEditorPropertyColorTest.class/instance/testTargetColorGetterAsString.st b/...package/AnimationsEditorPropertyColorTest.class/instance/testTargetColorGetterAsString.st
@@ -3,4 +3,4 @@ testTargetColorGetterAsString
 	| p |
 	p := AnimationsEditorPropertyColor new.
 
-	self assert: (p targetColorAsString =  p defaultTargetColor asString).
+	self assert: (p targetColorAsString =  (p defaultTargetColor asString copyReplaceAll: 'Color ' with: '')).
diff --git a/...mationsEditor-Tests.package/AnimationsEditorPropertyColorTest.class/methodProperties.json b/...mationsEditor-Tests.package/AnimationsEditorPropertyColorTest.class/methodProperties.json
@@ -4,7 +4,8 @@
 	"instance" : {
 		"testCanCreateAnimation" : "DM 8/7/2020 17:19",
 		"testCanRenderUI" : "DM 8/7/2020 17:19",
+		"testCreateAnimationForWithKeyWithLastKeyWithValueWithTargetValue" : "CL 5/23/2021 15:52",
 		"testInstanceCreation" : "DM 8/7/2020 17:19",
 		"testTargetColorGetter" : "DM 8/7/2020 17:32",
-		"testTargetColorGetterAsString" : "DM 8/7/2020 17:31",
+		"testTargetColorGetterAsString" : "CL 5/23/2021 14:50",
 		"testTargetColorSetter" : "DM 8/7/2020 17:21" } }
diff --git a/...onTest.class/instance/testCreateAnimationForWithKeyWithLastKeyWithValueWithTargetValue.st b/...onTest.class/instance/testCreateAnimationForWithKeyWithLastKeyWithValueWithTargetValue.st
@@ -0,0 +1,4 @@
+as yet unclassified
+testCreateAnimationForWithKeyWithLastKeyWithValueWithTargetValue
+
+	"test that it returns an animation according to the input values"
diff --git a/...ionsEditor-Tests.package/AnimationsEditorPropertyPositionTest.class/methodProperties.json b/...ionsEditor-Tests.package/AnimationsEditorPropertyPositionTest.class/methodProperties.json
@@ -4,6 +4,7 @@
 	"instance" : {
 		"testCanCreateAnimation" : "DM 8/7/2020 13:41",
 		"testCanRenderUI" : "DM 8/7/2020 13:42",
+		"testCreateAnimationForWithKeyWithLastKeyWithValueWithTargetValue" : "CL 5/23/2021 15:53",
 		"testInstanceCreation" : "DM 8/4/2020 13:33",
 		"testPositionXGetter" : "DM 8/7/2020 13:15",
 		"testPositionXSetter" : "DM 8/7/2020 13:13",

diff --git a/...onTest.class/instance/testCreateAnimationForWithKeyWithLastKeyWithValueWithTargetValue.st b/...onTest.class/instance/testCreateAnimationForWithKeyWithLastKeyWithValueWithTargetValue.st
@@ -0,0 +1,4 @@
+as yet unclassified
+testCreateAnimationForWithKeyWithLastKeyWithValueWithTargetValue
+
+	"test that it returns an animation according to the input values"
diff --git a/...ionsEditor-Tests.package/AnimationsEditorPropertyRotationTest.class/methodProperties.json b/...ionsEditor-Tests.package/AnimationsEditorPropertyRotationTest.class/methodProperties.json
@@ -4,6 +4,7 @@
 	"instance" : {
 		"testCanCreateAnimation" : "DM 8/7/2020 17:14",
 		"testCanRenderUI" : "DM 8/7/2020 17:14",
+		"testCreateAnimationForWithKeyWithLastKeyWithValueWithTargetValue" : "CL 5/23/2021 15:53",
 		"testInstanceCreation" : "DM 8/7/2020 17:14",
 		"testTargetRotationGetter" : "DM 8/7/2020 17:17",
 		"testTargetRotationGetterAsString" : "DM 8/7/2020 17:17",

diff --git a/...zeTest.class/instance/testCreateAnimationForWithKeyWithLastKeyWithValueWithTargetValue.st b/...zeTest.class/instance/testCreateAnimationForWithKeyWithLastKeyWithValueWithTargetValue.st
@@ -0,0 +1,4 @@
+as yet unclassified
+testCreateAnimationForWithKeyWithLastKeyWithValueWithTargetValue
+
+	"test that it returns an animation according to the input values"
diff --git a/...imationsEditor-Tests.package/AnimationsEditorPropertySizeTest.class/methodProperties.json b/...imationsEditor-Tests.package/AnimationsEditorPropertySizeTest.class/methodProperties.json
@@ -4,6 +4,7 @@
 	"instance" : {
 		"testCanCreateAnimation" : "DM 8/7/2020 17:22",
 		"testCanRenderUI" : "DM 8/7/2020 17:22",
+		"testCreateAnimationForWithKeyWithLastKeyWithValueWithTargetValue" : "CL 5/23/2021 15:53",
 		"testHeightGetter" : "DM 8/7/2020 17:26",
 		"testHeightSetter" : "DM 8/7/2020 17:26",
 		"testInstanceCreation" : "DM 8/7/2020 17:22",

diff --git a/...nimationsEditorPropertyTest.class/instance/testCreateCompositeAnimationForWithStartEnd.st b/...nimationsEditorPropertyTest.class/instance/testCreateCompositeAnimationForWithStartEnd.st
@@ -0,0 +1,4 @@
+as yet unclassified
+testCreateCompositeAnimationForWithStartEnd
+
+	"test that orderedColl containing all the animations is generated correctly based on a given key-value array"
diff --git a/...e/AnimationsEditorPropertyTest.class/instance/testOnlyPlaysAnimationInsideStartEndTime.st b/...e/AnimationsEditorPropertyTest.class/instance/testOnlyPlaysAnimationInsideStartEndTime.st
@@ -0,0 +1,4 @@
+as yet unclassified
+testOnlyPlaysAnimationInsideStartEndTime
+
+	"test that createCompositeAnimationFor:withStartEnd: only inserts those animations that are inside our time bounds"
diff --git a/...ests.package/AnimationsEditorPropertyTest.class/instance/testPlayAnimationWithStartEnd.st b/...ests.package/AnimationsEditorPropertyTest.class/instance/testPlayAnimationWithStartEnd.st
@@ -0,0 +1,4 @@
+as yet unclassified
+testPlayAnimationWithStartEnd
+
+	"test that building of compAnim works"
diff --git a/...package/AnimationsEditorPropertyTest.class/instance/testShowMessageKeyframeOutOfBounds.st b/...package/AnimationsEditorPropertyTest.class/instance/testShowMessageKeyframeOutOfBounds.st
@@ -0,0 +1,4 @@
+as yet unclassified
+testShowMessageKeyframeOutOfBounds
+
+	"test that createCompositeAnimationFor:withStartEnd: outputs warning message if keyframes out of start/endtime"
diff --git a/...s/AnimationsEditor-Tests.package/AnimationsEditorPropertyTest.class/methodProperties.json b/...s/AnimationsEditor-Tests.package/AnimationsEditorPropertyTest.class/methodProperties.json
@@ -3,7 +3,11 @@
 		 },
 	"instance" : {
 		"testComparators" : "DM 8/4/2020 13:46",
+		"testCreateCompositeAnimationForWithStartEnd" : "CL 5/23/2021 15:45",
 		"testEmptySubProperties" : "DM 8/4/2020 13:47",
 		"testHasSubProperties" : "DM 8/4/2020 13:47",
 		"testInstanceCreation" : "DM 8/4/2020 13:47",
-		"testSetTitle" : "DM 8/4/2020 13:46" } }
+		"testOnlyPlaysAnimationInsideStartEndTime" : "CL 5/23/2021 15:55",
+		"testPlayAnimationWithStartEnd" : "CL 5/23/2021 15:46",
+		"testSetTitle" : "DM 8/4/2020 13:46",
+		"testShowMessageKeyframeOutOfBounds" : "CL 5/23/2021 15:48" } }
diff --git a/...ionsEditor-Tests.package/AnimationsEditorTest.class/instance/animationsEditorInstance..st b/...ionsEditor-Tests.package/AnimationsEditorTest.class/instance/animationsEditorInstance..st
@@ -0,0 +1,4 @@
+accessing
+animationsEditorInstance: anObject
+
+	animationsEditorInstance := anObject.
diff --git a/...tionsEditor-Tests.package/AnimationsEditorTest.class/instance/animationsEditorInstance.st b/...tionsEditor-Tests.package/AnimationsEditorTest.class/instance/animationsEditorInstance.st
@@ -0,0 +1,4 @@
+accessing
+animationsEditorInstance
+
+	^ animationsEditorInstance
diff --git a/packages/AnimationsEditor-Tests.package/AnimationsEditorTest.class/instance/setUp.st b/packages/AnimationsEditor-Tests.package/AnimationsEditorTest.class/instance/setUp.st
@@ -0,0 +1,9 @@
+initialize-release
+setUp
+	| morph |
+
+	super setUp.
+	self animationsEditorInstance: AnimationsEditor open.
+	morph := Morph new.
+	morph openInWorld.
+	self animationsEditorInstance addTargetMorph: morph.
diff --git a/packages/AnimationsEditor-Tests.package/AnimationsEditorTest.class/instance/tearDown.st b/packages/AnimationsEditor-Tests.package/AnimationsEditorTest.class/instance/tearDown.st
@@ -0,0 +1,5 @@
+initialize-release
+tearDown 
+	(self animationsEditorInstance propertyList at: 2) targetMorph owner abandon. 
+	(self animationsEditorInstance propertyList at: 2) targetMorph abandon. 
+	self animationsEditorInstance windowReference abandon.
diff --git a/.../AnimationsEditor-Tests.package/AnimationsEditorTest.class/instance/testPlayAnimations.st b/.../AnimationsEditor-Tests.package/AnimationsEditorTest.class/instance/testPlayAnimations.st
@@ -9,13 +9,18 @@ testPlayAnimations
 
 	self flag: #todo.
 	positionProperty := ((animationsEditorInstance propertyList at: 2) subproperties at: 3).
+
+	animationsEditorInstance selectedTreeNode: positionProperty.
+
 	positionProperty positionX: 555.
 	positionProperty positionY: 555.
+	positionProperty frame: 500.
+	positionProperty addKeyframe.
 
-	animationsEditorInstance selectedTreeNode: positionProperty.
 	animationsEditorInstance playAnimations.	
 
 	animationsEditorInstance windowReference abandon.
+	morph owner abandon. 
 	morph abandon.
 
 	self assert: true. "no errors = good"
diff --git a/...sEditor-Tests.package/AnimationsEditorTest.class/instance/testShowMessagePlayAnimation.st b/...sEditor-Tests.package/AnimationsEditorTest.class/instance/testShowMessagePlayAnimation.st
@@ -0,0 +1,4 @@
+initialize-release
+testShowMessagePlayAnimation
+
+	"test that 'Playing selected Animation' is shown"
diff --git a/packages/AnimationsEditor-Tests.package/AnimationsEditorTest.class/methodProperties.json b/packages/AnimationsEditor-Tests.package/AnimationsEditorTest.class/methodProperties.json
@@ -2,12 +2,17 @@
 	"class" : {
 		 },
 	"instance" : {
+		"animationsEditorInstance" : "CL 5/23/2021 15:02",
+		"animationsEditorInstance:" : "CL 5/23/2021 15:02",
+		"setUp" : "CL 5/23/2021 15:31",
+		"tearDown" : "CL 5/23/2021 15:33",
 		"testEmptyPanelsGetter" : "DM 8/7/2020 17:52",
 		"testEmptyPanelsSetter" : "DM 8/7/2020 17:37",
 		"testGetDeepestMorph" : "DM 8/4/2020 13:26",
 		"testInstanceCreation" : "DM 8/4/2020 13:26",
-		"testPlayAnimations" : "DM 8/7/2020 19:05",
+		"testPlayAnimations" : "CL 5/23/2021 15:35",
 		"testSelectMorphByHand" : "DM 8/7/2020 18:59",
+		"testShowMessagePlayAnimation" : "CL 5/23/2021 15:49",
 		"testToolBuilderGetter" : "DM 8/7/2020 17:53",
 		"testToolBuilderSetter" : "DM 8/7/2020 17:53",
 		"testTreeSpecProperty" : "DM 8/7/2020 18:59",

diff --git a/packages/AnimationsEditor-Tests.package/AnimationsEditorTest.class/properties.json b/packages/AnimationsEditor-Tests.package/AnimationsEditorTest.class/properties.json
@@ -6,7 +6,7 @@
 		 ],
 	"commentStamp" : "",
 	"instvars" : [
-		 ],
+		"animationsEditorInstance" ],
 	"name" : "AnimationsEditorTest",
 	"pools" : [
 		 ],