Skip to content

Commit

Permalink
refactored zero duration test
Browse files Browse the repository at this point in the history
  • Loading branch information
Ol-Ba committed Jul 30, 2022
1 parent f4f8ed5 commit e67fbcf
Show file tree
Hide file tree
Showing 9 changed files with 20 additions and 32 deletions.
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
eventHandling
deleteMorph
"NEEDS REFACTORING"
"selected tree node needs to be set to some property when the morph is added"


"not tested on other morphs apart from normal morph"

self selectedTreeNode ifNil: [self updateInformationText: self messageNoMorphSelected. ^ 'break'].
Expand All @@ -13,24 +13,8 @@ deleteMorph
self updateInformationText: self messageMorphDeleted.


"to do: delete the JSON! for that look in animations editor property animated >> deleteAllKeyframes"

" self selectedTreeNode ifNil: [^ 'break'].
Transcript show: self selectedTreeNode; cr.
to do: delete the JSON! for that look in animations editor property animated >> deleteAllKeyframes
self propertyTreeMorph update: self propertyTreeMorph getChildrenSelector.
self updateInformationText: self messageMorphDeleted.
self selectedTreeNode ifNil:[self updateInformationText: self messageNoMorphExistingNoActivatedProperty.].
need to terminate process for each property
self selectedTreeNode process terminate." "doesnot work
self clearPropertyEditorPanel.
self timeline clearTimeline.
self selectedTreeNode: nil. "



Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"createTextPropertyOn:" : "LW 7/26/2021 16:44",
"defaultEmptyPanels" : "DM 8/7/2020 17:37",
"defaultPropertyPanelPosition" : "mjs 7/31/2021 16:18",
"deleteMorph" : "lka 7/21/2022 16:55",
"deleteMorph" : "ob 7/30/2022 17:22",
"editorTitle" : "LH 8/4/2020 10:31",
"editorTitle:" : "DM 8/3/2020 15:40",
"emptyPanels" : "DM 8/7/2020 17:37",
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
testing
setUp
| morph referenceTime |
| morph |

super setUp.
self referenceTime: WorldState lastCycleTime.
Expand All @@ -11,4 +11,5 @@ setUp
self timeline: self animationsEditorInstance timeline.
self propertyPosition isActivated: true.
self animationsEditorInstance selectedTreeNode: self propertyPosition.
self positionTrack: (self timeline submorphs at: 2).
self positionTrack: (self timeline submorphs at: 2).
self timebar: self animationsEditorInstance timeline timebar.
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
testing
testZeroDurationAtStart
Transcript show: self timeline timebar duration contents; cr.

self assert: self timeline timebar duration contents = self defaultDurationString.
self assert: self timebar duration contents = (self timebar getDurationString: 0).
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
accessing
timebar: anObject
timebar := anObject
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
accessing
timebar
^ timebar
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
"animationsEditorInstance:" : "MH 8/1/2021 18:42",
"calculateKeyframeCenterOn:" : "NB 8/1/2021 14:07",
"createKeyframeWith:on:" : "SG 6/22/2022 14:15",
"defaultDurationString" : "NR 7/18/2022 18:04",
"endFrame" : "MH 8/1/2021 18:42",
"endMargin" : "ob 5/29/2022 17:48",
"frameNumber1000" : "NR 7/18/2022 11:13",
Expand All @@ -26,7 +25,7 @@
"referenceTime:" : "NR 7/18/2022 11:36",
"runCase" : "NR 7/18/2022 11:36",
"secondLastOn:" : "NB 8/1/2021 12:16",
"setUp" : "NR 7/18/2022 11:46",
"setUp" : "ob 7/30/2022 17:38",
"startFrame" : "MH 8/1/2021 18:42",
"startMargin" : "ob 5/29/2022 17:46",
"tearDown" : "SG 6/22/2022 14:15",
Expand All @@ -39,7 +38,9 @@
"testMovingLineInitializedInRightPosition" : "NR 7/18/2022 11:40",
"testMovingLineStoppedAtEndMargin" : "NR 7/18/2022 11:51",
"testWidthOfTimeline" : "NR 7/18/2022 11:11",
"testZeroDurationAtStart" : "NR 7/18/2022 18:04",
"testZeroDurationAtStart" : "ob 7/30/2022 17:38",
"timebar" : "ob 7/30/2022 17:35",
"timebar:" : "ob 7/30/2022 17:35",
"timeline" : "MH 8/1/2021 18:43",
"timeline:" : "MH 8/1/2021 18:43",
"wait:" : "NR 7/18/2022 11:42",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
"positionTrack",
"addedKeyframeMorph",
"movingLine",
"referenceTime" ],
"referenceTime",
"timebar" ],
"name" : "AnimationsEditorTimelineTest",
"pools" : [
],
Expand Down

0 comments on commit e67fbcf

Please sign in to comment.