-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #77 from hpi-swa-teaching/refactoring/testsAndNull…
…Object Refactoring/tests and null object
- Loading branch information
Showing
36 changed files
with
97 additions
and
143 deletions.
There are no files selected for viewing
5 changes: 0 additions & 5 deletions
5
packages/AnimationsEditor-Core.package/AnimationsEditorMovingLine.class/class/on..st
This file was deleted.
Oops, something went wrong.
6 changes: 6 additions & 0 deletions
6
...es/AnimationsEditor-Core.package/AnimationsEditorMovingLine.class/class/on.withExtent..st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
initialization | ||
on: anAnimationsEditorTimeline withExtent: anotherPoint | ||
^ self basicNew timeline: anAnimationsEditorTimeline; | ||
initialize; | ||
extent: anotherPoint ; | ||
yourself. |
7 changes: 0 additions & 7 deletions
7
...Editor-Core.package/AnimationsEditorMovingLine.class/class/on.withPosition.withExtent..st
This file was deleted.
Oops, something went wrong.
7 changes: 0 additions & 7 deletions
7
...ditor-Core.package/AnimationsEditorMovingLine.class/class/on.withPositionY.withExtent..st
This file was deleted.
Oops, something went wrong.
8 changes: 4 additions & 4 deletions
8
...ges/AnimationsEditor-Core.package/AnimationsEditorMovingLine.class/instance/initialize.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
initialization | ||
initialize | ||
super initialize. | ||
self | ||
extent: 3@100; | ||
color: Color black; | ||
position: self startMargin@25. | ||
self | ||
color: Color black; | ||
position: self startMargin @ self trackHeight; | ||
playMovingAnimation. |
3 changes: 0 additions & 3 deletions
3
...es/AnimationsEditor-Core.package/AnimationsEditorMovingLine.class/instance/movingLine..st
This file was deleted.
Oops, something went wrong.
3 changes: 0 additions & 3 deletions
3
...ges/AnimationsEditor-Core.package/AnimationsEditorMovingLine.class/instance/movingLine.st
This file was deleted.
Oops, something went wrong.
12 changes: 12 additions & 0 deletions
12
...tionsEditor-Core.package/AnimationsEditorMovingLine.class/instance/playMovingAnimation.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
accessing | ||
playMovingAnimation | ||
| animation | | ||
animation:= (AnimPropertyAnimation | ||
on: self | ||
property: #position | ||
start: self position | ||
end: self position + (self animationDuration@0) | ||
duration: self animationDuration) | ||
start; | ||
register; | ||
finishBlock: [self abandon]. |
3 changes: 0 additions & 3 deletions
3
...ges/AnimationsEditor-Core.package/AnimationsEditorMovingLine.class/instance/positionY..st
This file was deleted.
Oops, something went wrong.
3 changes: 0 additions & 3 deletions
3
...ages/AnimationsEditor-Core.package/AnimationsEditorMovingLine.class/instance/positionY.st
This file was deleted.
Oops, something went wrong.
3 changes: 0 additions & 3 deletions
3
...package/AnimationsEditorMovingLine.class/instance/setMovingSpeedPerHundredMilliseconds.st
This file was deleted.
Oops, something went wrong.
3 changes: 0 additions & 3 deletions
3
packages/AnimationsEditor-Core.package/AnimationsEditorMovingLine.class/instance/speed..st
This file was deleted.
Oops, something went wrong.
3 changes: 0 additions & 3 deletions
3
packages/AnimationsEditor-Core.package/AnimationsEditorMovingLine.class/instance/speed.st
This file was deleted.
Oops, something went wrong.
9 changes: 0 additions & 9 deletions
9
packages/AnimationsEditor-Core.package/AnimationsEditorMovingLine.class/instance/step.st
This file was deleted.
Oops, something went wrong.
3 changes: 0 additions & 3 deletions
3
packages/AnimationsEditor-Core.package/AnimationsEditorMovingLine.class/instance/stepTime.st
This file was deleted.
Oops, something went wrong.
18 changes: 3 additions & 15 deletions
18
...ages/AnimationsEditor-Core.package/AnimationsEditorMovingLine.class/methodProperties.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,7 @@ | ||
{ | ||
"class" : { | ||
"on:" : "SG 5/21/2022 16:01", | ||
"on:withPosition:withExtent:" : "ob 6/9/2022 21:39", | ||
"on:withPositionY:withExtent:" : "ob 6/9/2022 21:40" }, | ||
"on:withExtent:" : "Noel Bastubbe 7/4/2022 15:27" }, | ||
"instance" : { | ||
"addMovingLine" : " 6/17/2022 14:09:28", | ||
"animationDuration" : "ob 6/9/2022 21:31", | ||
"initialize" : "ob 6/9/2022 21:29", | ||
"lineWidth" : "ob 6/9/2022 20:18", | ||
"movingLine" : " 6/17/2022 14:09:28", | ||
"movingLine:" : " 6/17/2022 14:09:28", | ||
"positionY" : "ob 6/9/2022 21:26", | ||
"positionY:" : "ob 6/9/2022 21:26", | ||
"setMovingSpeedPerHundredMilliseconds" : "ob 6/9/2022 21:31", | ||
"speed" : "ob 6/9/2022 20:26", | ||
"speed:" : "ob 6/9/2022 20:26", | ||
"step" : "ob 6/9/2022 20:45", | ||
"stepTime" : "Noel Bastubbe 6/22/2022 12:27" } } | ||
"initialize" : "Noel Bastubbe 7/12/2022 11:42", | ||
"playMovingAnimation" : "Noel Bastubbe 7/12/2022 11:57" } } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 0 additions & 3 deletions
3
packages/AnimationsEditor-Core.package/AnimationsEditorTimebar.class/instance/lineWidth.st
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 6 additions & 6 deletions
12
packages/AnimationsEditor-Core.package/AnimationsEditorTimeline.class/instance/initialize.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
initialization | ||
initialize | ||
super initialize. | ||
self | ||
extent: self initialExtent; | ||
color: Color lightGray; | ||
setDefaultProperty; | ||
initializeStartEndTime. | ||
super initialize. | ||
self | ||
extent: self initialExtent; | ||
color: Color lightGray; | ||
setDefaultProperty; | ||
initializeStartEndTime. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
...mationsEditor-Tests.package/AnimationsEditorTimelineTest.class/instance/referenceTime..st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
accessing | ||
referenceTime: anObject | ||
referenceTime := anObject |
3 changes: 3 additions & 0 deletions
3
...imationsEditor-Tests.package/AnimationsEditorTimelineTest.class/instance/referenceTime.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
accessing | ||
referenceTime | ||
^ referenceTime |
6 changes: 6 additions & 0 deletions
6
...ges/AnimationsEditor-Tests.package/AnimationsEditorTimelineTest.class/instance/runCase.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
testing | ||
runCase | ||
|
||
AnimAnimationRegistry | ||
value: AnimAnimationRegistry new | ||
during: [super runCase]. |
3 changes: 2 additions & 1 deletion
3
packages/AnimationsEditor-Tests.package/AnimationsEditorTimelineTest.class/instance/setUp.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 10 additions & 14 deletions
24
...ests.package/AnimationsEditorTimelineTest.class/instance/testMovingLineInRightPosition.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 5 additions & 6 deletions
11
...s.package/AnimationsEditorTimelineTest.class/instance/testMovingLineStoppedAtEndMargin.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
packages/AnimationsEditor-Tests.package/AnimationsEditorTimelineTest.class/instance/wait..st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
calculation | ||
support | ||
wait: milliseconds | ||
"Wait some time in terms of the main world cycle. Split up waiting time into slices of 5 virtual milliseconds to get close to the real behavior." | ||
|
||
self waitNow: 0. | ||
milliseconds // 5 timesRepeat: [self waitNow: 5]. | ||
milliseconds // 5 timesRepeat: [self waitNow: 5]. |
4 changes: 2 additions & 2 deletions
4
...es/AnimationsEditor-Tests.package/AnimationsEditorTimelineTest.class/instance/waitNow..st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
calculation | ||
support | ||
waitNow: milliseconds | ||
|referenceTime| | ||
|
||
referenceTime := referenceTime + milliseconds. | ||
AnimAnimationRegistry value updateAnimations: referenceTime. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters