Addressing Benjamins review #2

hpi-swa-teaching · Jun 20, 2021 · 8ae9be2 · 8ae9be2
1 parent 2ebed0c
commit 8ae9be2
Show file tree

Hide file tree

Showing 8 changed files with 8 additions and 14 deletions.
diff --git a/...ance/parseIdOfWorkflowAt.ofRepository..st → ...class/instance/parseIdAt.ofRepository..st b/...ance/parseIdOfWorkflowAt.ofRepository..st → ...class/instance/parseIdAt.ofRepository..st
@@ -1,5 +1,5 @@
 parsing
-parseIdOfWorkflowAt: aNumber ofRepository: aJson
+parseIdAt: aNumber ofRepository: aJson
 
 	| workflows workflow |
 

diff --git a/packages/AutoTDD-Core.package/ATDDGitHubActionsParser.class/methodProperties.json b/packages/AutoTDD-Core.package/ATDDGitHubActionsParser.class/methodProperties.json
@@ -4,7 +4,7 @@
 	"instance" : {
 		"parseHeadBranchAt:ofRepository:" : "sw 5/23/2021 16:23",
 		"parseHeadCommitOf:" : "ng 5/22/2021 18:46",
-		"parseIdOfWorkflowAt:ofRepository:" : "ClassTest 6/14/2021 17:40",
+		"parseIdAt:ofRepository:" : "ClassTest 6/20/2021 17:02",
 		"parseJobsOf:" : "sw 5/23/2021 16:47",
 		"parseLatestWorkflowRun:" : "ng 5/14/2021 16:02",
 		"parseMessageAt:ofRepository:" : "sw 5/23/2021 16:28",

diff --git a/packages/AutoTDD-Dummy-Category.package/ClassGettingTested.class/instance/bla.st b/packages/AutoTDD-Dummy-Category.package/ClassGettingTested.class/instance/bla.st
@@ -1,4 +1,3 @@
 action
 bla
-
-	ATDDBrowserTests setTestHasRun.
+ATDDBrowserTests setTestHasRun.
diff --git a/packages/AutoTDD-Dummy-Category.package/ClassGettingTested.class/methodProperties.json b/packages/AutoTDD-Dummy-Category.package/ClassGettingTested.class/methodProperties.json
@@ -2,4 +2,4 @@
 	"class" : {
 		 },
 	"instance" : {
-		"bla" : "ClassTest 6/19/2021 02:08" } }
+		"bla" : "" } }
diff --git a/packages/AutoTDD-Tests.package/ATDDGitHubActionParserTest.class/instance/testWorkflowId.st b/packages/AutoTDD-Tests.package/ATDDGitHubActionParserTest.class/instance/testWorkflowId.st
@@ -4,6 +4,6 @@ testWorkflowId
 	| parser id |
 
 	parser := ATDDGitHubActionsParser new.
-	id := parser parseIdOfWorkflowAt: 1 ofRepository: self sampleWorkflowRuns.
+	id := parser parseIdAt: 1 ofRepository: self sampleWorkflowRuns.
 
 	self assert: id isNumber
diff --git a/packages/AutoTDD-Tests.package/ATDDGitHubActionParserTest.class/methodProperties.json b/packages/AutoTDD-Tests.package/ATDDGitHubActionParserTest.class/methodProperties.json
@@ -10,4 +10,4 @@
 		"testWorkflow" : "ClassTest 6/14/2021 17:32",
 		"testWorkflowConclusion" : "ClassTest 6/14/2021 17:44",
 		"testWorkflowHistory" : "ClassTest 6/14/2021 17:22",
-		"testWorkflowId" : "ClassTest 6/14/2021 17:42" } }
+		"testWorkflowId" : "ClassTest 6/20/2021 17:02" } }
diff --git a/packages/AutoTDD-Tests.package/ATDDGitHubActionTest.class/instance/testConfiguration.st b/packages/AutoTDD-Tests.package/ATDDGitHubActionTest.class/instance/testConfiguration.st
@@ -8,12 +8,7 @@ testConfiguration
 	gitHubAction repositoryURL: self repoURL.
 	"how to test for valid token?, how to test for invalid token?"
 	gitHubAction token: '9'.
-	[ self assert: gitHubAction token = '9'. ]
-		"on: ATDDAccessDeniedError"
-		on: GHAAccessDeniedError
-		do: [
-
-		].
+	self assert: gitHubAction token = '9'.
 	self assert: gitHubAction name = 'Hello World'.
 	self assert: gitHubAction repository class = ATDDGitHubActionsRepository.
 	self assert: gitHubAction repositoryURL = self repoURL.

diff --git a/packages/AutoTDD-Tests.package/ATDDGitHubActionTest.class/methodProperties.json b/packages/AutoTDD-Tests.package/ATDDGitHubActionTest.class/methodProperties.json
@@ -5,5 +5,5 @@
 		"repoURL" : "ClassTest 6/14/2021 13:18",
 		"setUp" : "ClassTest 6/14/2021 13:18",
 		"tearDown" : "ClassTest 6/14/2021 13:19",
-		"testConfiguration" : "ClassTest 6/20/2021 16:52",
+		"testConfiguration" : "ClassTest 6/20/2021 16:59",
 		"testPauseResumeRun" : "ClassTest 6/14/2021 21:04" } }